in reply to Re^3: Please critique this script -- Read emails and write URLs into bookmarks
in thread Please critique this script -- Read emails and write URLs into bookmarks

I forgot to check URI::Find->new as well. Thanks for that.

About the others, maybe I should elaborate my ideology here:

I usually prefer technical error messages to 'clean' ones. Especially when I'm not perfectly sure where the errors could come from or if I don't have the time to check all odds and ends. The rationale being that my own error messages could only be worse.

The errors are handled. They produce descriptive (if not overly verbose) messages. But in a script of this nature developer and user are usually quite close. So this verbosity turns out to be very useful.

However, checking the number of input arguments and checking if $uris is not empty are clearly omissions which I will fix.

  • Comment on Re^4: Please critique this script -- Read emails and write URLs into bookmarks
  • Download Code

Replies are listed 'Best First'.
Re^5: Please critique this script -- Read emails and write URLs into bookmarks
by Anonymous Monk on Oct 06, 2016 at 19:49 UTC
    Actually $subject (if empty) and the output filepath (if exists) should be checked as well.
      Hold the phone, I'm talking out of my ass here. There's actually no error handling going on, only error messages. Yeah, I need error-handling code.