in reply to Re: Propose addition to use warnings?
in thread Propose addition to use warnings?

Thanks davido, I figured I may be asking for too much, but I wasn't sure so I asked the Monastery.

...that's not a reasonable place, because Perl doesn't really know the purpose of my_sub, and doesn't know at this point what you are planning to do with $first_fh.

That is where I would have requested the warning to be given, basically a "you already closed this filehandle, are you sure you still want to be using it for anything at all?" sort of warning. If it's not reasonable it's not reasonable. I suppose I'm just being the guy trying to blame his tools when it's actually his own ineptitude at using them that's the problem. :-)

Just another Perl hooker - will code for food

Replies are listed 'Best First'.
Re^3: Propose addition to use warnings?
by davido (Cardinal) on Nov 28, 2016 at 19:36 UTC

    I didn't mean for "not reasonable" to sound like your request is unreasonable. Just that setting the warning there isn't ideal because my_sub could be something like: 

    sub my_sub {
    my $closed_handle = shift;
    die "For some reason our handle isn't closed yet."
        if $closed_handle->opened;
}

    [download]

    ...or

    close $fh or my_sub($fh);

sub my_sub {
    my $handle = shift;
    my $error = $handle->error;
    die "Got this error code: $error\n" if $error;
}

    [download]

    ...or even...

    # Open a handle only if it's not opened.
sub my_sub {
    open $_[0], '<', $_[1] if !$_[0]->opened;
}

    [download]

    Dave

[reply]
[d/l]
[select]

In Section Meditations