Global symbol "$fnames" requires explicit package

This specific error is because you have an array named @fnames but you later try to dereference an undeclared arrayref named $fnames.

You've also got an issue with the part of your syntax that tries to access the element within the array:

@$fnames->{filename}
[download]

If, as seems possible from the code you posted, you are receiving into your sub listdirs() two arguments, each a reference to an array, you can get what I think you want with:

my $res_files = list_dirs($dir,$datanames);

sub list_dirs {
   my ( $locations, $fnames ) = @_;
   ...
   foreach my $href ( @{ $fnames } ) {
       my $filename = $href{'filename'};
       # do something with filename ...
   }
}
[download]

my $res_files = list_dirs($dir,$datanames);

sub list_dirs {
   my ( $locations, $fnames ) = @_;

   my @filenames = map { $_->{'filename'} } @{ $fnames };
   ...
}
[download]

And in general, in Perl, there's usually a tool to do something common like what you want. You might like to use Path::Iterator::Rule:

use Path::Iterator::Rule;
...
my $res_files = list_dirs($dir,$datanames);

sub list_dirs {
   my ( $locations, $fnames ) = @_;
   # assumes each is a simple arrayref

   my $finder = Path::Iterator::Rule->new;
   $finder->name( @{ $fnames } );
   my $get_next_match = $finder->iter( @{ $locations } );

   my @found_filenames;
   while ( defined ( my $match = $get_next_match->() ) ) {
       push @found_filenames, $match;
   }

   return \@found_filenames;
}
[download]

See also Yes, even you can use CPAN.

Hope this helps!

Great explanation, but how would I use this line or the array @filenames:


my @filenames = map { $_->{'filename'} } @{ $fnames };
[download]


in this line:


find( { wanted => sub { push @files, $_ unless $_ eq '.' || $_ eq '..'
+ || $_ !~ m/@filenames$/} , no_chdir => 1 }, @dirs);
[download]


That's where I am trying to understand the most, thanks!

I found that this way, it works:


my @filenames = map { $_->{'filename'} } @{ $fnames };
my $rx_fnames = join '|', @filenames;
 find( { wanted => sub { push @files, $_ unless $_ eq '.' || $_ eq '..
+' || $_ !~ m/$rx_fnames$/} , no_chdir => 1 }, @dirs);
[download]


Any feed back is welcome!

#!/usr/bin/perl
use strict;
use warnings;

use 5.012;
# http://perldoc.perl.org/File/Find.html
use File::Find; 
# http://perldoc.perl.org/Getopt/Long.html
use Getopt::Long; 
 
my @locations;
my @fnames;

my $verbose;
my $ignorecase;
GetOptions (
          "location=s"   => \@locations, 
          "filename=s"   => \@fnames,
          "ignorecase"  => \$ignorecase,
          "verbose"  => \$verbose)
or die("Error in command line arguments @ARGV\n");

my $USAGE = "$0 -l <directory> -f <filename> [-v]
example:
$0 -l /var/www/allfiles -f abc122.txt -f 333twom.txt -f 56test.txt -f 
+t445ok.txt
";

die $USAGE unless @fnames;
die $USAGE unless @locations;

my @files;

find({ wanted => \&process, follow => 0, no_chdir => 1 }, @locations);

sub process{
    my $addfile = 0;
    for my $f (@fnames){
        print "Considering '$_' in $f \n" if $verbose;
        if(index($_,$f)>-1){
            ++$addfile;
            last;
        }
    }
    push @files, $File::Find::name if $addfile;
}

use Data::Dumper; 
print Dumper \@files;
[download]

For a start, try renaming  my @fnames = shift; to  my $fnames = shift; (untested)

you should inform yourself about the differences between plain @arrays and $array_references.

And please remove the pod block, it's not a good approach to uncomment code.

I am sorry, here is a better sample of what I meant:


#!/usr/bin/perl

use strict;
use warnings;

use File::Find qw(finddepth);
use File::Find qw(find);

...

my ($dir,$datanames); # These var(s) has values been passed to the sub

my $res_files = list_dirs($dir,$datanames);

sub list_dirs {
    
 my @locations = shift;
 my $fnames = shift;

my @files;
 find(
       {
       wanted => sub { push @files, $_ unless $_ eq '.' || $_ eq '..' 
+|| $_ !~ m/@$fnames->[0]{filename}$/} , no_chdir => 1 }, @locations);

 print Dumper \@files;
 return \@files;

 }
 
# This is after DUMP of the data.
=code
 my @locations = [
          '/var/www/allfiles'
        ];

 my $fnames = [
          {
            'filename' => 'abc122.txt'
          },
          {
            'filename' => '333twom.txt'
          },
          {
            'filename' => '56test.txt'
          },
          {
            'filename' => 't445ok.txt'
          }
        ];
=cut
[download]