Re^2: Recognizing 3 and 4 digit number

G'day Dave,

At first glance, I thought your regex was better than mine and so I decided to try it. I plugged it into my code but it failed on the phone number and date tests (details in spoiler). The OP requirements are not the best but excluding phone numbers and dates seems to be definitely wanted.

The code changed as follows:

#my $re = qr{(?x: (?<![/-]) \b ( [0-9]{3,4} ) \b (?![/-]) )};
my $re = qr{(?ax: (?<!\d) (\d{3,4}) (?!\d) )};
[download]

Output:

1..10
ok 1 - Testing: 12
ok 2 - Testing: 123
ok 3 - Testing: 1234
ok 4 - Testing: 12345
ok 5 - Testing: 123 4567 890
ok 6 - Testing: 123 4567 89
not ok 7 - Testing: 123-4567-890
#   Failed test 'Testing: 123-4567-890'
#   at ./pm_1178784_regex_digits.pl line 29.
#          got: '>123<>123<->4567<>4567<->890<>890<'
#     expected: '123-4567-890'
not ok 8 - Testing: 01/02/2017
#   Failed test 'Testing: 01/02/2017'
#   at ./pm_1178784_regex_digits.pl line 29.
#          got: '01/02/>2017<>2017<'
#     expected: '01/02/2017'
not ok 9 - Testing: 2017-01-02T17:01:34
#   Failed test 'Testing: 2017-01-02T17:01:34'
#   at ./pm_1178784_regex_digits.pl line 29.
#          got: '>2017<>2017<-01-02T17:01:34'
#     expected: '2017-01-02T17:01:34'
ok 10 - Testing: 12
# 345
# 6789
# 0
# Looks like you failed 3 tests of 10.
[download]

— Ken

Comment on Re^2: Recognizing 3 and 4 digit number Select or Download Code

Replies are listed 'Best First'.
Re^3: Recognizing 3 and 4 digit number by davido (Cardinal) on Jan 03, 2017 at 17:53 UTC
Wah! I guess I got excited and answered before noticing that we wanted to disqualify things that look like phone numbers. Sorry. This isn't tested: `m/(?<![\d-])(\d{3,4})(?![\d-])/` [download] But it would run afoul of phone numbers using commas to separate, or wrapping parens around area codes. It might be useful to take a first pass and keep a list of offsets for "numbers" that should be ignored. It's probably easier to match a phone number with existing libraries than to match a 3 or 4 digit number that is not part of a phone number. In other words, on first pass, identify phone numbers, IP addresses, and other problematic numbers, and push their offsets and lengths into an array. Then on second pass disqualify any number that falls within one of the offset/length sets. Dave	[reply] [d/l]

Replies are listed 'Best First'.

Re^3: Recognizing 3 and 4 digit number
by davido (Cardinal) on Jan 03, 2017 at 17:53 UTC

Wah! I guess I got excited and answered before noticing that we wanted to disqualify things that look like phone numbers. Sorry.

This isn't tested:

m/(?<![\d-])(\d{3,4})(?![\d-])/
[download]

But it would run afoul of phone numbers using commas to separate, or wrapping parens around area codes.

It might be useful to take a first pass and keep a list of offsets for "numbers" that should be ignored. It's probably easier to match a phone number with existing libraries than to match a 3 or 4 digit number that is not part of a phone number. In other words, on first pass, identify phone numbers, IP addresses, and other problematic numbers, and push their offsets and lengths into an array. Then on second pass disqualify any number that falls within one of the offset/length sets.

Dave

[reply]
[d/l]