Hi skasch,

Assuming that difference in the two strings pointed out in the AM post is just a copy/paste mistake and you meant to say "_A_domain_D_com" instead of "_A_albertbauer_D_com", the reason why your code isn't working as intended is \b. This matches the boundary between a word (\w) and non-word (\W) character. \w is discussed in detail here, but to simplify, under ASCII (/a) it's the set [a-zA-Z0-9_]. Note how it includes letters, digits, and the underscore. Therefore, the string user_A_domain_D_com_BCA contains no internal word bounaries, and the regex you are trying to match it against, /\b_A_domain_D_com_\b/ will not match that string.

Having said that, note how in your solution you're having to maintain two sets of regexes: %replacements and the long if statement. While it's possible this is necessary due to the structure of the data (I don't know all your requirements), note that there are ways to express the same stuff without the repetition. Here's one way to dynamically build the regex:

my %replacements = (...);
my $regex = join '|',
    map {quotemeta}
    sort { length $b <=> length $a }
    keys %replacements;
$regex = qr/$regex/;
# ...
while ( <$readFile> ) {
    s/($regex)/$replacements{$1}/g;
    print $_;
}
[download]

And if you need to check for the presence of the strings "Calendar" / "Contacts" / "Users", as in your example code, you can combine the multiple regexes into something like /:(?:Calendar|Contacts)(?=\/)|(?<=\"\/)Users/ (Update: shortened regex slightly).

One more thing: Mind the Meta! Note how the %replacements key user.name@domain.com contains two dots - in your current solution, those will match any character. Only if you say \Q$key\E (or manually use quotemeta as I showed above) will the dots and any other special regex chars be matched literally.

Hope this helps,
-- Hauke D

In the code you've shown, you don't need s/.../.../

$key = $replacements{$key};
[download]

Hi 1nickt,

In the code you've shown, you don't need s/.../.../

$key = $replacements{$key};
[download]

I'm not sure I'm understanding your post...? This doesn't work:

foreach my $key ( sort keys %replacements ) {
    $key = $replacements{$key};
}
[download]

Regards,
-- Hauke D

Hi haukex,

you are right it was a typo.

Thank you very much for your insights regarding the word boundaries and also those on literally matching, did not take it into account so far.

I changed both in my code and now it works as intended, I do not yet fully understand to build a regex dynamically though. But i do understand the possiblity to write more elegant code

so finally still with repetition and static ;-)

if ( m/:Calendar(?=\/)/ or
     m/:Contacts(?=\/)/ or
     m/(?<=\"\/)Users/ or
     m/.+@.+\"\s=/ or
     m/_A_domain_D_com/ ) {
          foreach my $key ( sort keys %replacements ) {
                  s/\Q$key\E/$replacements{$key}/g;
                  }
     }
[download]

Indeed that helped Hauke, thanks!

Sascha