in reply to Re: Does "preallocating hash improve performance"? Or "using a hash slice"?
in thread Does "preallocating hash improve performance"? Or "using a hash slice"?
While this is of course true, you missed vr's point about hash slices. With @h{ @keys } = @values; perl could use the size of the keys list to preallocate the hash. I guess this would turn out to be a waste of space if most of the keys are duplicates, which would explain why apparently setting all the keys "at once" seems to still require several reallocations.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^3: Does "preallocating hash improve performance"? Or "using a hash slice"?
by BrowserUk (Patriarch) on Feb 20, 2017 at 18:14 UTC | |
you missed vr's point about hash slices. Not so much "missed it" as chose not to address it. With @h{ @keys } = @values; perl could use the size of the keys list to preallocate the hash The problem with that is that in order to gain the 18% saving from the preallocation of my 10,000,000 key hash, the hash slice would: It's a lot more complicated than that, but it is sufficiently accurate to make my point.) So, now the process not only has two copies of all the keys and values (in the arrays as well as the hash), it also has allocated enough space to store them all again on the stack. So that means the peak memory usage required to do the slice assignment is at least 4 times more than is eventually required to construct the hash itself; and the hash was not preallocated either! Slice assignment can be more efficient for relatively small hashes provided it is necessary to the rest of the code to have the keys and values stored in arrays as well. But if you are loading them into arrays, simply so that you can use list assignment to construct a hash from them, it is a disaster in terms of both memory usage and processing time. And for anything larger then pretty modest sized hashes ( a few 10s or low 100s of key/value pairs) then the cost (memory and time) of building the two lists on the stack far outweights any gain from moving the loop into C. Especially as the potential of having the hash pre-sized doesn't happen. (It probably could, but it doesn't.) With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority". The enemy of (IT) success is complexity.
In the absence of evidence, opinion is indistinguishable from prejudice.
| [reply] |
by Eily (Monsignor) on Feb 21, 2017 at 10:15 UTC | |
I hope perl is not so inefficient that it copies all the content of a list when it needs to process it, when simply pointing to the already allocated elements would be enough. Even more so with arrays. I'd also expect some COW mechanism to remove a lot of allocating and copying. Keys might be more trouble though, as all data stored in them have to be stringified first (and I wouldn't be surprised to learn that hash keys always hold a copy of the initial string, since as far as I can tell they are not standard scalar values). I agree that the memory usage, and number of copies is certainly higher when you go all the way to slicing, but I don't expect "at least 4 times more" memory. Actually I remember finding out in a post a while ago that having the keys and values in two arrays takes more place than just having them in a hash (which kind of makes sense, order is extra information, although technically I think it's because keys can afford to just be strings, without all the extras of ordinary scalar values) Not so much "missed it" as chose not to address it.Well that's too bad, you did have an interresting answer: that if you need to gather your data in some form before populating your hash, you shouldn't expect to obtain the best result memory-wise and time-wise (because of the copies). So you probably don't need to worry about preallocation if you don't need to worry about slicing. | [reply] |
by BrowserUk (Patriarch) on Feb 21, 2017 at 20:58 UTC | |
Okay, let me try responding to this again. Blow by blow this time. I hope perl is not so inefficient that it copies all the content of a list when it needs to process it, when simply pointing to the already allocated elements would be enough. Even more so with arrays. Um. The example contains arrays. So if the previous sentence was not talking about arrays, what was it talking about? I'd also expect some COW mechanism to remove a lot of allocating and copying. CopyOnWrite generally applies to entire data segments of a process that is cheaply shared with another process; that's obviously not applicable here. Perl does have some internal flags and references with "COW" in their names; where by the copying of scalars is avoided (by aliasing) until and unless they are written to; but as the argument lists (destination & source) to op_aassign are inherently readonly, that does not apply here either. Keys might be more trouble though, as all data stored in them have to be stringified first (and I wouldn't be surprised to learn that hash keys always hold a copy of the initial string, since as far as I can tell they are not standard scalar values). Since CoW is not applicable to the destination and source lists; most of that is irrelevant, but I can confirm that hash keys are not normal scalars, and even if they are already in memory as scalars, the text will be copied into the HV structure. I agree that the memory usage, and number of copies is certainly higher when you go all the way to slicing, but I don't expect "at least 4 times more" memory. For the statement: @hash{ @keys } = @array; here is the memory usage:
So, final memory usage: 4,394,716 K - initial memory usage: 9,356 K = memory used by the two arrays, the final hash and all the intermediate allocations for the stack, smaller versions of the hash during construction and other bits & bobs: 4,385,360 K or 4490608640 bytes. And, 4490608640 / 783106748 = 5.734350586901084908030954676437. Your expectations are wrong. I can't see any value going further. With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority". The enemy of (IT) success is complexity.
In the absence of evidence, opinion is indistinguishable from prejudice.
| [reply] [d/l] [select] |
by huck (Prior) on Feb 21, 2017 at 21:29 UTC | |
by Eily (Monsignor) on Feb 22, 2017 at 13:34 UTC | |
by BrowserUk (Patriarch) on Feb 21, 2017 at 15:37 UTC | |
I hope perl is not so inefficient that it copies all the content of a list when it needs to process it, Hoping doesn't change anything; I described what the code (perl sources) actually do; it is your choice whether to believe me or not. You could always check for yourself: <Reveal this spoiler or all in this thread>
Well that's too bad, Oh, sorry. I wasn't aware you had joined the Answers Approval Subcommittee? if you need to gather your data ... Are you sure that what I said? With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority". The enemy of (IT) success is complexity.
In the absence of evidence, opinion is indistinguishable from prejudice.
| [reply] [d/l] |
by Eily (Monsignor) on Feb 21, 2017 at 17:02 UTC | |