in reply to Re: recurse directories and sub-directories
in thread recurse directories and sub-directories

You're much better off using File::Find than reinventing the wheel like this.

Firstly, your code will only work on Windows, or any other OS where the directory separator is \. File::Find deals with this transparently. Also you're not checking for failure. What happens if the chdir ($d) fails, maybe because the directory specified in $d doesn't exist?

The first two lines to match for the current or parent directory could be rewritten as next if $file =~ /^\.{1,2}$/;.

Replies are listed 'Best First'.
Re:x3 recurse directories and sub-directories (bad code warning)
by grinder (Bishop) on Oct 12, 2001 at 16:38 UTC
    The first two lines to match for the current or parent directory could be rewritten as next if $file =~ /^\.{1,2}$/;.

    But it would be better not to, because it is a potential time-bomb waiting to explode. Why do people keep dragging out this broken regexp, when a couple of conditionals will do the trick?

    next if $file eq '.' or $file eq '..';

    --
    g r i n d e r
[reply]
[d/l]
[select]

      For the sake of defensive programming, and to be cross platform compatible, you could also use File::Spec::Functions to be safe.

      File::Spec::Functions has two routines that will return the characters used to represent the current and upper directory for your specific operating system. While it may be true that most OS's use "." and ".." to represent the current directory and upper directory, it may not necessarily be garaunteed. If it was, I doubt these functions would have been put into the module in the first place. =)

      Here's your example using File::Spec::Functions:

      use File::Spec::Functions qw(curdir updir);

#..

next if $file eq curdir or $file eq updir;

      [download]
[reply]
[d/l]

In Section Seekers of Perl Wisdom