Re: capture optional text

use strict;
use warnings;
use Data::Dumper;

my %hosts;
while (chomp(my $line = <DATA>)) {
    my ($key,$val) = split /\s+/, $line, 2;
    $hosts{$key} = $val;
}

print Dumper \%hosts;

__DATA__
XYZ1ADAIQ1   #AMI
XYZ1ADECQ1   #OAG
XYZ1ADEDQ1
XYZ1ADEDQ2   ##DMS Host
[download]

Comment on Re: capture optional text Download Code

Replies are listed 'Best First'.
Re^2: capture optional text by haukex (Archbishop) on May 18, 2017 at 13:55 UTC
`while (chomp(my $line = <DATA>)) {` This won't work if the final line doesn't end on a newline, as chomp returns the number of newlines it removed. Better to use the traditional `while (<DATA>) { chomp; ...` or `while (my $line = <DATA>) { chomp($line); ...` Update: Plus, even with a trailing newline, the code generates a warning, since after the final line, the loop condition is executed one more time, and `<DATA>` will return `undef` and `chomp(my $line = undef)` causes a warning.	[reply] [d/l] [select]
Re^2: capture optional text by Lotus1 (Vicar) on May 18, 2017 at 13:32 UTC
Split should have been my first choice but I didn't think of it. Very nice, thanks.	[reply]