open fails to open file when filename read from STDIN

Nicpetbio23! has asked for the wisdom of the Perl Monks concerning the following question:

Why doesn't this read my file into the array properly? How can I fix it

-----------------------------------------------------------------------

print "Please enter id file\n";
my $file = <STDIN>;
open (my $handle, '<',$file);
chomp (my @lines = <$handle>);
close $handle;
[download]

Comment on open fails to open file when filename read from STDIN Download Code

Replies are listed 'Best First'.
Re: open fails to open file when filename read from STDIN by LanX (Saint) on Jul 09, 2017 at 17:31 UTC
I think you need to `chomp $file` too. in any case you need to check for errors from `open`: `open(my $fh, "<", "input.txt") or die "Can't open < input.txt: $!";` Cheers Rolf _{(addicted to the Perl Programming Language and ☆☆☆☆ :) Je suis Charlie!}	[reply] [d/l] [select]
Re: open fails to open file when filename read from STDIN by hippo (Archbishop) on Jul 09, 2017 at 21:04 UTC
Item number 7 on the Basic debugging checklist	[reply]
Re^2: open fails to open file when filename read from STDIN by KurtZ (Friar) on Jul 09, 2017 at 23:14 UTC
Plus number 2 (and 3). :)	[reply]
Re: open fails to open file when filename read from STDIN by Anonymous Monk on Jul 09, 2017 at 17:29 UTC
There's a newline on the end of the filename, which you need to get rid of. Also, always error-check your opens. `my $file = <STDIN>; chomp $file; open my $handle, '<', $file or die "Can't read $file: $!";` [download]	[reply] [d/l]
Re: open fails to open file when filename read from STDIN by karlgoethebier (Abbot) on Jul 10, 2017 at 09:30 UTC
TMTOWTDI with the error handling for free: `#!/usr/bin/env perl use strict; use warnings; use Path::Tiny; use Data::Dump; use feature qw(say); say q(Please enter id file); chomp( my $file = <STDIN> ); my @data = path($file)->lines( { chomp => 1 } ); dd \@data; __END__` [download] Regards, Karl ŤThe Crux of the Biscuit is the Apostropheť `perl -MCrypt::CBC -E 'say Crypt::CBC->new(-key=>'kgb',-cipher=>"Blowfish")->decrypt_hex($ENV{KARL});'`Help	[reply] [d/l] [select]