Input Hash Values Into Subroutine

FIJI42 has asked for the wisdom of the Perl Monks concerning the following question:

So I've written a code that checks to see if a key from Hash1 exists in Hash2.

When the select keys are found, I wish to pass the values associated with those keys (i.e. a nucelotide sequence) into a subroutine to space and label the rows/columns of the sequence. However, I'm not sure how to do this properly - possibly through referencing/dereferencing the hash?</p?

The main body of the code is below:

    foreach my $samekeys (sort keys %hash1) {
        if (exists $hash2{$samekeys}){          
                
                ntSpacer(????);
                
        }
    }

sub ntSpacer{
  
    my $myseq= 
    my $space;                            

        ### Prints number on top line to show groups of 10 nucleotides

        print "              1".$space."         2".$space."         3
+".$space."         4".$space."         5".$space.
              "         6".$space."         7".$space."         8".$sp
+ace."         9".$space."        10"."\n";

        ### Prints numbers per nucleotide, per groups of 10.

        print "Line".$space."1234567890".$space."1234567890".$space."1
+234567890".$space."1234567890".$space."1234567890".$space."1234567890
+".        $space."1234567890".$space."1234567890".$space."1234567890"
+.$space."1234567890"."\n";

                ## For loop to set 100 nucleotides as maximum length o
+f each line
        
                my $line_number=0;                                 
        for (my $i=0; $i<length($myseq); $i=$i+100){     
            $line_number=$line_number+1;
             my $seq100=substr($myseq,$i,100);
             
              ## If line number is greater than or equal to 10, print 
+with custom spacing.

            if ($line_number>=10) {                    
                 print "  $line_number ";
            }
             
            else {
                 print "   $line_number ";             
             }
     
          ## Divides every 100 nucleotides into groups of 10 with spac
+es.

             for (my $j=0; $j<length($seq100); $j=$j+10) {
                      my $seq10 = substr($seq100,$j,10);
                    print "$seq10".$space;
                         
                ## ^ Prints nucleotide sequence with spacers incorpora
+ted into it.
             }    
        }
}
[download]

The end result I want is something like this, for multiple values (i.e. nucleotide sequences):

        1          2          3          4          5          6
Line 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890
   1 GGAAAAACAT TTCATCTTAA AACTTTCCTA AGACAAGGGA AAACAAAAAA CCATGCTCTA
   2 TTTTTCTTAC AAAGAAAAAT TTAATATTCG ATGAGAGGTT GAACCAGGCT TAAAGCAGAC
   3 ATGGTGCAGC CTGTAAGAAT GCCAGTTTGT AAGTACTGAC TTTGGAAAAG ATCATCGCCT
   4 CTTAGGGTCC TGGTCTGGCA ATTTTGGCCT GATGTGATGC CACAAGACCC AACAGAGAGA
   5 CCAGGATAAT GTTGACAGTG GTGTAGCCCT TTAGGAGAAA TGGCGCTCCC TGCGGCTGGT
   6 CATTGGCACC GAAGGAACCA GGAGGATAAG AATATCCATA ATTTCAGAGC TGCCCTGGCA
   7 CCCGTCGGAG GCTCTCACTG GCAAATGACA GCTCTGTGCA AGGAGCACTC CCAAGTATAA
   8 ACAGTTTTAT TCTGAAGAAC ATTTTGCATT TTAATAAAAA AGGATTTATG TCAGGAAAGA

              1          2          3          4          5          6
Line 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890
   1 GGAAAAACAT TTCATCTTAA AACTTTCCTA AGACAAGGGA AAACAAAAAA CCATGCTCTA
   2 TTTTTCTTAC AAAGAAAAAT TTAATATTCG ATGAGAGGTT GAACCAGGCT TAAAGCAGAC
   3 ATGGTGCAGC CTGTAAGAAT GCCAGTTTGT AAGTACTGAC TTTGGAAAAG ATCATCGCCT
   4 CTTAGGGTCC TGGTCTGGCA ATTTTGGCCT GATGTGATGC CACAAGACCC AACAGAGAGA
   5 CCAGGATAAT GTTGACAGTG GTGTAGCCCT TTAGGAGAAA TGGCGCTCCC TGCGGCTGGT
   6 CATTGGCACC GAAGGAACCA GGAGGATAAG AATATCCATA ATTTCAGAGC TGCCCTGGCA
   7 CCCGTCGGAG GCTCTCACTG GCAAATGACA GCTCTGTGCA AGGAGCACTC CCAAGTATAA
   8 ACAGTTTTAT TCTGAAGAAC ATTTTGCATT TTAATAAAAA AGGATTTATG TCAGGAAAGA


   etc.
[download]

Any suggestions are much appreciated.

Comment on Input Hash Values Into Subroutine Select or Download Code

Replies are listed 'Best First'.
Re: Input Hash Values Into Subroutine by NetWallah (Canon) on Oct 23, 2017 at 17:16 UTC
It is not clear from your question WHICh hash contents you need. Here is how to show both: `ntSpacer($hash1{$samekeys}); ntSpacer($hash2{$samekeys}); } } sub ntSpacer{ my ($myseq) = @_; .. process and print $myseq...` [download] I would want to pass some indication of WHICH hash, and which key was being printed. for that, change the param to : `my ($myseq, $hashname, $key) = @_;` [download] And the call becomes: `ntSpacer($hash2{$samekeys}, "HASH2", $samekeys);` [download] All power corrupts, but we need electricity.	[reply] [d/l] [select]
Re^2: Input Hash Values Into Subroutine by FIJI42 (Acolyte) on Oct 23, 2017 at 19:12 UTC
Sorry for not specifying. I just needed to run the subroutine for each value in %hash2. Since the subroutine only expects a single string as output, the code you provided works well: `ntSpacer($hash2{$samekeys});` Here's the output I was looking for - thanks! 1 2 3 4 5 6 + 7 8 9 10 Line 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 + 1234567890 1234567890 1234567890 1234567890 1 GTGTCTGGAT TCTATATAAA AACTTTCCTA AGACAAGGGA AAACAAAAAA CCATGCTCTA + CAACTTCAAA TTTTTCTTAC AAAGAAAAAT TTAATATTCG 2 ATGAGAGGTT GAACCAGGCT TAAAGCAGAC ATACTAGGAA ATGGTGCAGC CTGTAAGAAT + GCCAGTTTGT AAGTACTGAC TTTGGAAAAG ATCATCGCCT 3 CTATCAGACA CTTAGGGTCC TGGTCTGGCA ATTTTGGCCT GATGTGATGC CACAAGACCC + AACAGAGAGA GACACAGAGT CCAGGATAAT GTTGACAGTG 4 GTGTAGCCCT TTAGGAGAAA TGGCGCTCCC TGCGGCTGGT ATTAGGTTAC CATTGGCACC + GAAGGAACCA GGAGGATAAG AATATCCATA ATTTCAGAGC 5 TGCCCTGGCA CAGTACCTGC CCCGTCGGAG GCTCTCACTG GCAAATGACA GCTCTGTGCA + AGGAGCACTC CCAAGTATAA AAATTATTAC ACAGTTTTAT 6 TCTGAAGAAC ATTTTGCATT TTAATAAAAA AGGATTTATG TCAGGAAAGA GTCATTTACA + AACCTTGAAG TGTTTTTGCC TGGATCAGAG TAAGAATGTC 7 TTAAGAAGAG GTTTGTAAGG TCTTCAATAA AAAGTGGTGT TTGTTATTTA CAATTTTTTT + TTTTAAAAAA ATTAACAGGT TGTCTGTATA CTATTAAAAA 8 TGGGGGGGGG GGGGAAAAAA AAAAAAAAAA AA 1 2 3 4 5 6 + 7 8 9 10 Line 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 + 1234567890 1234567890 1234567890 1234567890 1 GGATAATGTT GACAGTGGTG TAGCCCTTTA GGAGAAATGG CGCTCCCTGC GGCTGGTATT + AGGTTACCAT TGGCACCGAA GGAACCAGGA GGATAAGAAT 2 ATCCATAATT TCAGAGCTGC CCTGGCACAG TACCTGCCCC GTCGGAGGCT CTCACTGGCA + AATGACAGCT CTGTGCAAGG AGCACTCCCA AGTATAAAAA 3 TTATTACACA GTTTTATTCT GAAGAACATT TTGCATTTTA ATAAAAAAGG ATTTATGTCA + GGAAAGAGTC ATTTACAAAC CTTGAAGTGT TTTTGCCTGG 4 ATCAGAGTAA GAATGTCTTA AGAAGAGGTT TGTAAGGTCT TCATAATAAA GTGGTGTTTG + TTATTTACAA AAAAAAAAAA AAAAAAAATT AACAGGTTGT 5 CTGTATACTA TTAAAAATTT TGGACCAAAA AAAAAAAAAA [download]	[reply] [d/l] [select]
Re: Input Hash Values Into Subroutine by hippo (Archbishop) on Oct 23, 2017 at 17:18 UTC
It looks like your subroutine expects a single string as its argument, so just pass that. `if (exists $hash2{$samekeys}) { ntSpacer ($hash2{$samekeys}); } # ... sub ntSpacer { my $myseq = shift; # ... do other stuff }` [download]	[reply] [d/l]
Re^2: Input Hash Values Into Subroutine by Anonymous Monk on Oct 23, 2017 at 19:05 UTC
Sometimes the easiest solution is the one I made a note of 2 months ago and forgot ... Yes, I just needed to run the subroutine for each value of %hash2 - so this works great and prints the right output as seen below (note: it's 10 columns long, but forum posts seem to squish the code a bit). Thanks! 1 2 3 4 5 6 + 7 8 9 10 Line 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 + 1234567890 1234567890 1234567890 1234567890 1 GTGTCTGGAT TCTATATAAA AACTTTCCTA AGACAAGGGA AAACAAAAAA CCATGCTCTA + CAACTTCAAA TTTTTCTTAC AAAGAAAAAT TTAATATTCG 2 ATGAGAGGTT GAACCAGGCT TAAAGCAGAC ATACTAGGAA ATGGTGCAGC CTGTAAGAAT + GCCAGTTTGT AAGTACTGAC TTTGGAAAAG ATCATCGCCT 3 CTATCAGACA CTTAGGGTCC TGGTCTGGCA ATTTTGGCCT GATGTGATGC CACAAGACCC + AACAGAGAGA GACACAGAGT CCAGGATAAT GTTGACAGTG 4 GTGTAGCCCT TTAGGAGAAA TGGCGCTCCC TGCGGCTGGT ATTAGGTTAC CATTGGCACC + GAAGGAACCA GGAGGATAAG AATATCCATA ATTTCAGAGC 5 TGCCCTGGCA CAGTACCTGC CCCGTCGGAG GCTCTCACTG GCAAATGACA GCTCTGTGCA + AGGAGCACTC CCAAGTATAA AAATTATTAC ACAGTTTTAT 6 TCTGAAGAAC ATTTTGCATT TTAATAAAAA AGGATTTATG TCAGGAAAGA GTCATTTACA + AACCTTGAAG TGTTTTTGCC TGGATCAGAG TAAGAATGTC 7 TTAAGAAGAG GTTTGTAAGG TCTTCAATAA AAAGTGGTGT TTGTTATTTA CAATTTTTTT + TTTTAAAAAA ATTAACAGGT TGTCTGTATA CTATTAAAAA 8 TGGGGGGGGG GGGGAAAAAA AAAAAAAAAA AA 1 2 3 4 5 6 + 7 8 9 10 Line 1234567890 1234567890 1234567890 1234567890 1234567890 1234567890 + 1234567890 1234567890 1234567890 1234567890 1 GGATAATGTT GACAGTGGTG TAGCCCTTTA GGAGAAATGG CGCTCCCTGC GGCTGGTATT + AGGTTACCAT TGGCACCGAA GGAACCAGGA GGATAAGAAT 2 ATCCATAATT TCAGAGCTGC CCTGGCACAG TACCTGCCCC GTCGGAGGCT CTCACTGGCA + AATGACAGCT CTGTGCAAGG AGCACTCCCA AGTATAAAAA 3 TTATTACACA GTTTTATTCT GAAGAACATT TTGCATTTTA ATAAAAAAGG ATTTATGTCA + GGAAAGAGTC ATTTACAAAC CTTGAAGTGT TTTTGCCTGG 4 ATCAGAGTAA GAATGTCTTA AGAAGAGGTT TGTAAGGTCT TCATAATAAA GTGGTGTTTG + TTATTTACAA AAAAAAAAAA AAAAAAAATT AACAGGTTGT 5 CTGTATACTA TTAAAAATTT TGGACCAAAA AAAAAAAAAA [download]	[reply] [d/l]
Re: Input Hash Values Into Subroutine by 1nickt (Canon) on Oct 23, 2017 at 17:19 UTC
Hi, you assign to the variable each time through the loop, so it only ever holds one key. Just pass the value if it exists: `for my $found_key ( sort keys %hash1 ) { if ( exists $hash2{ $found_key } ) { ntSpacer( $hash2{ $found_key } ); } } sub ntSpacer { my $seq = shift; ... }` [download] Hope this is all you were looking for ... I didn't check the sub (although it seems you are using the undefined value as a spacer) The way forward always starts with a minimal test.	[reply] [d/l]