in reply to Re: Missing "Vote" button
in thread Missing "Vote" button

That's not entirely correct, you can vote on the replies if you open them individually, like Re: Modern Perl 4th Edition .

I looked into the code yesterday, and review display page lacks inclusion of votehead and votefoot to include the form and submit button.

There are recent patches mentioning voteit from jdporter, but I have trouble grasping them.

I could create new patches, but I'd like to first discuss them with jdporter, who is absent at the moment.

Understanding the monastery mechanics is not straight forward. ..

Cheers Rolf
(addicted to the Perl Programming Language and ☆☆☆☆ :)
Je suis Charlie!

update

Added deeplinks into the code which are only accessible for some cabal

Replies are listed 'Best First'.
Re^3: Missing "Vote" button
by Happy-the-monk (Canon) on Nov 18, 2017 at 12:24 UTC

    That's not entirely correct, you can vote on the replies if you open them individually.

    I think Athanasius may have meant exactly that: you can vote on the replies only, but not on the thread's first node Modern Perl 4th Edition/1203697 itself.

    At least that is what I have understood.

    Cheers, Sören

    Créateur des bugs mobiles - let loose once, run everywhere.
    (hooked on the Perl Programming language)

[reply]
Re^3: Missing "Vote" button (patch)
by LanX (Saint) on Nov 19, 2017 at 22:04 UTC
    > I looked into the code yesterday, and review display page lacks inclusion of votehead and votefoot to include the form and submit button.

    I submitted a patch which should fix it for reviews , let's see what happens after the gods applied it.

    I can only guess that jdporter planned some refactoring in March 2016, but I wasn't able to locate the "voteformcontainer" he's mentioning.

    Cheers Rolf
    (addicted to the Perl Programming Language and ☆☆☆☆ :)
    Je suis Charlie!

[reply]
      I submitted a patch which should fix it for reviews

      Thanks for that.
      Just yesterday, I got suckered again - different thread, but same issue.

      Cheers,
      Rob
[reply]
        Patch was applied and all reviews seem to be "votable" again.

        If you want to test: Book Reviews

        (Better don't test with the newest one since it's quite "disputed" ;)

        Cheers Rolf
        (addicted to the Perl Programming Language and ☆☆☆☆ :)
        Je suis Charlie!

[reply]

In Section Perl Monks Discussion