Re^2: Filtering Output from two files

#!/nairvigv/bin/perl
use strict;
use warnings;
use Data::Dumper;

my $file1 = 'BBIDs.txt';
my $file2 = 'fixedincomeTransparency.out.px.derived.updates';
#reading file1 into a hash

my %hash;
my @fields;
open (my $fh,'<',$file1) or die $!;
while(my $line=<$fh>)
{
chomp $line;
 next if $line =~ /^\s*$/;
 $hash{$line}=1;
}
#print Dumper(\%hash);

close $fh;



open (my ($fh2),$file2) or die $!;

while (my $row = <$fh2>)
 {
         chomp $row;

       print "$row\n";
         next if $row =~ /^\s*$/;
        my (@fields) = split(/\|/, $row);



print "$fields[0]\n ";




if (exists $hash{$fields[0]})
{
print "$row\n";
}
}


close $fh2;
~
[download]

Hello this works for a program with less lines i.e 10. However when i run it on a big file say about 700k lines nothing happens. Any idea what can be causing this?

Comment on Re^2: Filtering Output from two files Download Code

Replies are listed 'Best First'.
Re^3: Filtering Output from two files by LanX (Saint) on Feb 06, 2018 at 11:48 UTC
Due to broken indentation it's hard to read and I won't go into details. Have a look at http://perl.plover.com/FAQs/Buffering.html and basic debugging checklist Cheers Rolf _{(addicted to the Perl Programming Language and ☆☆☆☆ :) Wikisyntax for the Monastery}	[reply]
Re^4: Filtering Output from two files by vighneshmufc (Acolyte) on Feb 06, 2018 at 12:25 UTC
Sorry would indentation next time onwards. Basic what's happening is the big files have whitespace before and after each entry So I have to remove those while I store them to a key .	[reply]
Re^5: Filtering Output from two files (updated) by LanX (Saint) on Feb 06, 2018 at 12:39 UTC
> So I have to remove those while I store them to a key OK ... what is hindering you? :) update you are already using a regex to match empty lines, time to understand what they do perlre#Metacharacters `^ Match the beginning of the string Not in [] (or line, if /m is used) ... $ Match the end of the string Not in [], but can ... * Matches the preceding element 0 or more Not in [] times` [download] update and look again into marshall's code ;-) Cheers Rolf _{(addicted to the Perl Programming Language and ☆☆☆☆ :) Wikisyntax for the Monastery}	[reply] [d/l]
Re^4: Filtering Output from two files by vighneshmufc (Acolyte) on Feb 06, 2018 at 15:52 UTC
`open (my ($fh2),$file2) or die $!; while (my $row = <$fh2>) { chomp $row; print "$row\n"; next if $row =~ /^\s$/; my (@fields) = split(/\\|/, $row);` [download] so i have to add `$row =~ s/\s$//` after `next if $row =~ /^\s*$/;` and it will work? i cant really check from here since i am at home and would have to wait another 12 hours	[reply] [d/l] [select]
Re^5: Filtering Output from two files by hippo (Archbishop) on Feb 06, 2018 at 16:36 UTC
i cant really check from here since i am at home Install perl at home Mock up some sample data Run your code at home against the sample data Now you will know whether it works without having to wait.	[reply]