in reply to EMC VNX SCRIPT

Hello atulperl,

Welcome to the monastery. I have update a bit your code with some closing file calls and also some minor modifications chomp array etc. On my system this script runs under a second. Also I would suggest to use ssh key authentication instead of user name and password for many reason but mainly for security.

#!/usr/bin/perl
use strict;
use warnings;
use Net::SSH2;
use Date::Manip;

my $datestr = ParseDate("now");
my $dateHumanReadable = UnixDate($datestr, "Date: %T on %b %e, %Y.");

#get ip’s
#open file
my $ipFile = "ips2.txt";
open(my $FH, '<', $ipFile)
    or die ("Unable to open file '".$ipFile."': $!");
# read file into an array
chomp(my @data = <$FH>);
close $FH
    or warn "Unable to close file '".$ipFile."': $!";

my $ssh2 = Net::SSH2->new();

foreach my $sw (@data) {
    $ssh2->connect($sw, 22) or $ssh2->die_with_error; # port default 2
+2 update if you use other port

    $ssh2->auth( publickey => "/home/user/.ssh/id_rsa"); # ssh key aut
+hentication, update for user and password

    my $chan = $ssh2->channel()
    or $ssh2->die_with_error;

    $chan->blocking(1);

    $chan->exec("ls -la /home/user/Monks/Foo")
    or $ssh2->die_with_error;

    my $stdoutFileName = "stdout-$sw.txt";
    open(my $fhStdOut, '>', $stdoutFileName)
    or die "Could not open file '".$stdoutFileName."' $!";

    print $fhStdOut $dateHumanReadable;

    while (<$chan>){
    print $fhStdOut $_;
    }

    close $fhStdOut
    or warn "Unable to close file '".$stdoutFileName."': $!";

    my $stderrFileName = "stderr-$sw.txt";
    open(my $fhStdErr, '>', $stderrFileName)
    or die "Could not open file '".$stderrFileName."' $!";

    print $fhStdErr "exit status: " . $chan->exit_status . "\n";

    close $fhStdErr
    or warn "Unable to close file '".$stderrFileName."': $!";

    $ssh2->disconnect();
}

__END__

$ time perl test.pl

real    0m0.368s
user    0m0.127s
sys    0m0.008s

$ cat stdout-127.0.0.1.txt
Date: 13:45:44 on Aug  8, 2018.total 16
drwxrwxr-x  2 user user 4096 Feb 28 21:10 .
drwxrwxr-x 14 user user 4096 Aug  8 13:45 ..
-rw-rw-r--  1 user user  263 Feb 28 21:10 Bar.pm
-rw-rw-r--  1 user user  184 Jan 30  2018 Bar.pm~

$ cat stderr-127.0.0.1.txt
exit status: 0

[download]

Can you check how long your commands needs to be executed?

I think the reason that this delay is observed on your call because of the huge buffer that you set.

If for some reason this sample script does not work post your problem and I will try to assist more.

Update: I would also strongly suggest to read this small tutorial regarding the module from the forum see here: A little demo for Net::SSH2

Update2: Alternative solution is to use method read2 that captures stdout and stderr. Sample of code:

#!/usr/bin/perl
use strict;
use warnings;
use Net::SSH2;
use Date::Manip;

my $datestr = ParseDate("now");
my $dateHumanReadable = UnixDate($datestr, "Date: %T on %b %e, %Y.");

#get ip’s
#open file
my $ipFile = "ips2.txt";
open(my $FH, '<', $ipFile)
    or die ("Unable to open file '".$ipFile."': $!");
# read file into an array
chomp(my @data = <$FH>);
close $FH
    or warn "Unable to close file '".$ipFile."': $!";

my $ssh2 = Net::SSH2->new();

foreach my $sw (@data) {
    $ssh2->connect($sw, 22) or $ssh2->die_with_error;

    $ssh2->auth( publickey => "/home/user/.ssh/id_rsa");

    my $chan = $ssh2->channel()
    or $ssh2->die_with_error;

    $chan->blocking(1);

    $chan->exec("ls -la /home/user/Monks/Foo")
    or $ssh2->die_with_error;

    my ($out, $err) = ('', '');
    while (!$chan->eof) {
    if (my ($o, $e) = $chan->read2) {
        $out .= $o;
        $err .= $e;
    }
    else {
        $ssh2->die_with_error;
    }
    }

    my $stdoutFileName = "stdout-$sw.txt";
    open(my $fhStdOut, '>', $stdoutFileName)
    or die "Could not open file '".$stdoutFileName."' $!";

    print $fhStdOut "$dateHumanReadable\n\nSTDOUT:\n\n$out";

    close $fhStdOut
    or warn "Unable to close file '".$stdoutFileName."': $!";

    my $stderrFileName = "stderr-$sw.txt";
    open(my $fhStdErr, '>', $stderrFileName)
    or die "Could not open file '".$stderrFileName."' $!";

    print $fhStdErr "STDERR:\n\n$err" . "exit status: " . $chan->exit_
+status . "\n";

    close $fhStdErr
    or warn "Unable to close file '".$stderrFileName."': $!";

    $ssh2->disconnect();
}

__END__

$ time perl test.pl

real    0m0.389s
user    0m0.127s
sys    0m0.028s
$ cat stdout-127.0.0.1.txt
Date: 14:14:30 on Aug  8, 2018.

STDOUT:

total 16
drwxrwxr-x  2 user user 4096 Feb 28 21:10 .
drwxrwxr-x 14 user user 4096 Aug  8 14:14 ..
-rw-rw-r--  1 user user  263 Feb 28 21:10 Bar.pm
-rw-rw-r--  1 user user  184 Jan 30  2018 Bar.pm~

$ cat stderr-127.0.0.1.txt
STDERR:

exit status: 0

[download]

Update3: Alternative solution is to use module IO::All which will reduce your code significantly in reading/writing files etc. Sample of code:

#!/usr/bin/perl
use strict;
use IO::All;
use warnings;
use Net::SSH2;
use Date::Manip;

my $datestr = ParseDate("now");
my $dateHumanReadable = UnixDate($datestr, "Date: %T on %b %e, %Y.");

#get ip’s
#open file
my @data = io("ips2.txt")->chomp->slurp;

my $ssh2 = Net::SSH2->new();

foreach my $sw (@data) {
    $ssh2->connect($sw, 22) or $ssh2->die_with_error;

    $ssh2->auth( publickey => "/home/user/.ssh/id_rsa");

    my $chan = $ssh2->channel()
    or $ssh2->die_with_error;

    $chan->blocking(1);

    $chan->exec("ls -la /home/user/Monks/Foo")
    or $ssh2->die_with_error;

    my ($out, $err) = ('', '');
    while (!$chan->eof) {
    if (my ($o, $e) = $chan->read2) {
        $out .= $o;
        $err .= $e;
    }
    else {
        $ssh2->die_with_error;
    }
    }

    io("stdout-$sw.txt")->print("$dateHumanReadable\n\nSTDOUT:\n$out")
+;
    io("stderr-$sw.txt")->print("STDERR:\n$err" .
                "exit status: " .
                $chan->exit_status .
                "\n");

    $ssh2->disconnect();
}

__END__

$ time perl test.pl

real    0m0.389s
user    0m0.127s
sys    0m0.028s
$ cat stdout-127.0.0.1.txt
Date: 14:14:30 on Aug  8, 2018.

STDOUT:
total 16
drwxrwxr-x  2 user user 4096 Feb 28 21:10 .
drwxrwxr-x 14 user user 4096 Aug  8 14:14 ..
-rw-rw-r--  1 user user  263 Feb 28 21:10 Bar.pm
-rw-rw-r--  1 user user  184 Jan 30  2018 Bar.pm~

$ cat stderr-127.0.0.1.txt
STDERR:
exit status: 0

[download]

Hope this helps, BR.

Seeking for Perl wisdom...on the process of learning...not there...yet!

Replies are listed 'Best First'.
Re^2: EMC VNX SCRIPT
by atulperl (Initiate) on Aug 09, 2018 at 10:13 UTC

    Hi Thanos, Thanks for the reply

    Issue with my script was not the time , but my issue is nas_Checkup command takes 15 min normally .But my script is not waiting that much minute to print the output in file. I want my script to wait till command fully runs.

[reply]

      Hello again atulperl,

      Unfortunately I can not replicate your problem. Can you give it a try on the sample of code Update3 I think this is the best approach of using Net::SSH2::Channel::read2 method, capable of capturing STDOUT and STDERR.

      If this fails can you provide the output what is the error code that is failing?

      P.S. why specifically this module Net::SSH2 and not any other SSH module available e.g Net::OpenSSH?

      Hope this helps, BR.

      Seeking for Perl wisdom...on the process of learning...not there...yet!
[reply]
[d/l]

In Section Seekers of Perl Wisdom