Re: Problem with perlcritic when using Moose object (what perlcritic policy is complaining/broken? Perl::Critic::Policy::Freenode::DeprecatedFeatures)

The question is what perlcritic policy is complaining/broken?

 $ perlcritic --brutal --verbose=9 ....


[Freenode::DeprecatedFeatures] autoderef is deprecated at line 2, near
+ '$Person->shift( $foo );'.  (Severity: 4)

[Freenode::DeprecatedFeatures] autoderef is deprecated at line 4, near
+ '$Person->shift( $hash->{shift} );'.  (Severity: 4)
[download]

So this is a bug in Perl-Critic-Freenode-0.027 / Perl::Critic::Policy::Freenode::DeprecatedFeatures

A shift method isn't tested in https://metacpan.org/source/DBOOK/Perl-Critic-Freenode-0.027/t/Freenode/DeprecatedFeatures.run

Comment on Re: Problem with perlcritic when using Moose object (what perlcritic policy is complaining/broken? Perl::Critic::Policy::Freenode::DeprecatedFeatures) Download Code

Replies are listed 'Best First'.
Re^2: Problem with perlcritic when using Moose object (what perlcritic policy is complaining/broken? Perl::Critic::Policy::Freenode::DeprecatedFeatures) by Anonymous Monk on Oct 05, 2018 at 23:22 UTC
`shift(@goodArray); shift @$goodRef; shift @{$goodRef}; shift(@{$goodRef->{bar}[5]}); shift $goodRef->{bar}[5]->@*; shift; shift(); shift($bad->[5]); print +shift $bad; $Buggy->shift( $FalsePositive ); $Buggy->shift( $FalsePositive->{shift} );` [download]	[reply] [d/l]

Replies are listed 'Best First'.

Re^2: Problem with perlcritic when using Moose object (what perlcritic policy is complaining/broken? Perl::Critic::Policy::Freenode::DeprecatedFeatures)
by Anonymous Monk on Oct 05, 2018 at 23:22 UTC

shift(@goodArray);
shift @$goodRef;
shift @{$goodRef};
shift(@{$goodRef->{bar}[5]});
shift $goodRef->{bar}[5]->@*;
shift;
shift();
shift($bad->[5]);
print +shift $bad;
$Buggy->shift( $FalsePositive );
$Buggy->shift( $FalsePositive->{shift} );
[download]

[reply]
[d/l]