Re^2: Script help needed - RegEx & Hashes

All good points (++). One minor comment:

Please try to use consistent indentation.

From my quick eye-parse of the code, PandaRaey is using consistent indentation. It's just that their choice of indentation scheme (Whitesmiths) is unusual to see in Perl.

Comment on Re^2: Script help needed - RegEx & Hashes

Replies are listed 'Best First'.
Re^3: Script help needed - RegEx & Hashes by haukex (Archbishop) on Oct 10, 2018 at 11:34 UTC
Yes, you're right! (When I skimmed the code, the final `close`s jumped out at me as looking off, I'm obviously not used to this style.) Sorry, PandaRaey, this is Perl and There Is More Than One Way To Do It, you're free to use whatever indentation style you like, as long as it's consistent (which it is in this case). If I may make a minor comment though: some more whitespace in statements like `foreach$folder(@folders)` would make them a little easier to read, IMHO.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: Script help needed - RegEx & Hashes
by haukex (Archbishop) on Oct 10, 2018 at 11:34 UTC

Yes, you're right! (When I skimmed the code, the final closes jumped out at me as looking off, I'm obviously not used to this style.)

Sorry, PandaRaey, this is Perl and There Is More Than One Way To Do It, you're free to use whatever indentation style you like, as long as it's consistent (which it is in this case). If I may make a minor comment though: some more whitespace in statements like foreach$folder(@folders) would make them a little easier to read, IMHO.

[reply]
[d/l]
[select]