in reply to Re^7: Faster Luhn Check Digit Calculation?
in thread Faster Luhn Check Digit Calculation?

Update:Ignore this! It doesn't stand up to syphilis's scrutiny. (It only works for the OPs limited test range by luck!)

Looks fat to me ( just kidding :)

If its skinny you want, try this for (its lack of) size :)

Correct results and 35% faster to boot:

int lookup[] = { 8, 6, 4, 2, 0, 7, 5, 3, 1, 9, 7, 5, 3, 1, 9, 6, 4, 2,
+ 0 };
int c_fluhn( int n ) {
    return lookup[ n % 20 ];
}

[download]
With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority". The enemy of (IT) success is complexity.
In the absence of evidence, opinion is indistinguishable from prejudice. Suck that fhit

Replies are listed 'Best First'.
Re^9: Faster Luhn Check Digit Calculation?
by kschwab (Vicar) on Dec 02, 2018 at 21:55 UTC
    Very nice. Unfortunately, Algorithm::LUHN supports some odd inputs, like non-numeric strings (See their docs).
[reply]
      Algorithm::LUHN supports some odd inputs

      That module may attempt to extend the purpose and use of the algorithm to inputs for which it was never designed; but in doing so, it invalidates itself and the algorithm.

      Ie. The purpose of the algorithm is to catch 2 digit transposition errors in numeric identifiers; trying to extend that mathematics to non-numerics invalidates that purpose.

      Eg. The use of Mod 9, on alpha data that has a 26 character alphabet means that some (34% of) combinations of 2-digits transpositions will not be detected.

      Rules to live by:Don't perpetuate other people's bullshit.

      With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
      Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
      "Science is about questioning the status quo. Questioning authority". The enemy of (IT) success is complexity.
      In the absence of evidence, opinion is indistinguishable from prejudice. Suck that fhit
[reply]
        The module docs read like Standard & Poor's decided to do that, not the original module author, but I digress.
[reply]
      > Unfortunately, Algorithm::LUHN supports some odd inputs, like non-numeric strings

      Careful, is this algorithm well defined for input >=10 !?!

      From the docs:

      > For example, Standard & Poor's maps A..Z to 10..35 so the LIST to add these valid characters would be (A, 10, B, 11, C, 12, ...)

      provided B=11 is on an odd position, what's the formula now to reduce 2*11?

      cross total is 4, but 22-9 =13

      and if it's even does 11 stay 11 with cross total 2 or do you take it module 10 hence resulting in 1?

      Cheers Rolf
      (addicted to the Perl Programming Language :)
      Wikisyntax for the Monastery FootballPerl is like chess, only without the dice

[reply]

        Just replicating the original module, including a fairly straight port to C that's passing the original module's tests...

        Maybe I'll make a separate module that "does the right thing", but isn't compatible with Algorithm::LUHN.

[reply]

In Section Seekers of Perl Wisdom