Re^3: create clone script for utf8 encoding

"I don't even got how this code could run without a semi-colon after $winner ."

It's the last line of "sub highest_number { ... }". Technically, that is terminated by the final brace: while this is valid code, I wouldn't recommend it (certainly not for production code). The problem is that if more code is added you'll have a statement that is neither terminated by a brace nor a semicolon.

The same applies to arrays (and hashes) and commas. Consider this contrived example:

my @numbers = (
    'one',
    'three',
    'two'
);
[download]

Oops! I'll just reorder those (a simple ddp sequence in vi):

my @numbers = (
    'one',
    'two'
    'three',
);
[download]

Now you've got an even bigger "Oops!".

Having said that, the biggest, single improvement you could make to this code would be the use of consistent indentation. It took me some time, tracking back and forth between opening and closing braces, to see where the related blocks of code were. This type of code is highly error-prone. Perhaps look at perlstyle; and perltidy may prove useful.

— Ken

Comment on Re^3: create clone script for utf8 encoding Select or Download Code

Replies are listed 'Best First'.
Re^4: create clone script for utf8 encoding by choroba (Cardinal) on Dec 20, 2018 at 15:59 UTC
> The problem is that if more code is added you'll have a statement that is neither terminated by a brace nor a semicolon In fact, in my own code, I never put a semicolon after return: Adding code after `return $winner;` [download] makes no sense, as that code wouldn't be reachable. So I'm glad I'll get some kind of a syntax error. ($q=q:Sq=~/;[c](.)(.)/;chr(-\|\|-\|5+lengthSq)`"S\|oS2"`map{chr \|+ord }map{substrSq`S_+\|`\|}3E\|-\|`7**2-3:)=~y+S\|`+$1,++print+eval$q,q,a, [download]	[reply] [d/l] [select]
Re^5: create clone script for utf8 encoding by kcott (Archbishop) on Dec 21, 2018 at 03:12 UTC
I agree, code after a `return` is unreachable. The last sentence of that first paragraph ("The problem is ...") should really have been on a new paragraph; and it should have indicated a general case, rather than the specific case with `return`. I recall that being my thought process at the time, but clearly it didn't make it to my fingers whilst typing. Having said that, I would still recommend adding the semicolon. It clearly indicates where the statement was intended to end. Had an interruption occurred whilst coding, perhaps `return` was meant to be one of: `return; return $var;` [download] Or `return $var` was meant to be one of: `return $var; return $var if $condition;` [download] It's even possible there were meant to be more lines after `return $var`: `return $var ? 'TRUE' : 'FALSE';` [download] — Ken	[reply] [d/l] [select]
Re^5: create clone script for utf8 encoding by Aldebaran (Curate) on Jan 03, 2019 at 08:11 UTC
In fact, in my own code, I never put a semicolon after return Interesting, and thanks all for comments. I do try to work through the source posted, and this might be my final version of highest_number for this thread. I finally worked out what the glitch was in getting the next number after 9. Abridged output, then source: `$ ./2.cw1.pl ... object created, back with caller word is 2.cw dir2 is perlmonks 2.cw1.html 2.cw2.html ... 2.cw9.html 2.cw10.html 2.cw11.html ... matching is 2.cw9.html matching is 2.cw10.html matching is 2.cw11.html old num is 11 Make rus captions(y/n)?: n ... Put file to server(y/n)?: y server dir is perlmonks ... return is 2.cw12.html` [download] `sub highest_number { use 5.011; my ( $aref, $filetype, $word ) = @_; my $number; my @matching; my $ext = "." . $filetype; push( @matching, 0 ); #min returned value for my $file ( @{$aref} ) { #print "file is $file\n"; if ( $file =~ /^$word(\d+)$ext$/ ) { print "matching is $file\n"; push( @matching, $1 ); } } @matching = sort { $a <=> $b } @matching; my $winner = pop @matching; return $winner }` [download] I hadn't been sorting numerically. The existence of this page shows that the code works: resulting page. What's funny is that I presented with an algorithm I was embarrassed to show, but with the mere addition of `{ $a <=> $b }` and falling back to not having a semi-colon after the return, then I think this is pretty good, lexical perl.	[reply] [d/l] [select]
Re^4: create clone script for utf8 encoding by ikegami (Patriarch) on Dec 20, 2018 at 18:08 UTC
It also makes nicer diffs when adding lines to the list. You see a line being added instead of a line being changed up top of a line being added.	[reply]