Re: Contextual find and replace large config file

These are several different questions

First let me warn you that your code has an error

This will fail if you don't care about indentation:

    if ( $line =~ /ObjectType1/ ) {
        $context = "ObjectType1" ;
    }
    if ( $line =~ /\}/ ) {
        $context = "" ;
    }
[download]

Here you rather want to test for /$\}/ at lines start!

My suggestions

separate parsing of syntax logic from processing of semantic logic
parse all lines of an object into a cache ( a string or nested hashes) before handling it
with nested objects use recursion
keep track of the indentation level, like counting open and closed braces
you should handle parsing errors in case the input is corrupted
use functions and packages instead of piling up if cases
use a function dispatcher if you need to handle semantics of different "ObjectTypes"

Like this you will get reusable and maintainable code!

edit

some may miss example code, but you got a generic answer for a generic question.

Feel free to pick some points and ask for clarification.

Cheers Rolf
_{(addicted to the Perl Programming Language :)

Wikisyntax for the Monastery
FootballPerl is like chess, only without the dice}

Comment on Re: Contextual find and replace large config file Select or Download Code

Replies are listed 'Best First'.
Re^2: Contextual find and replace large config file by Veltro (Hermit) on Jan 03, 2019 at 11:06 UTC
Hi LanX, Yes, I was actually aware of that error, since you mentioned it I edited the OP Not strictly necessary to provide example code (plus others have already done so), I am just trying to redesign some code and trying to find a different approach. So your generic answer is welcome of course The only thing is what you mean with your first suggestion (separate parsing...semantic logic). What do you mean with that? Do you mean parsing and gathering data first and then split the processing of that data into different function blocks or something else? Thanks, Veltro	[reply]
Re^3: Contextual find and replace large config file by LanX (Saint) on Jan 03, 2019 at 14:49 UTC
> (separate parsing...semantic logic). What do you mean with that? Your two examples seem to hold the same information (semantic) while having different format (syntax). So better write parsers for the different formats which "cache" them in an intermediate format. These parsers should be ignorant about the meaning just concentrating on correctness. The semantics - the meaning of the data - could be handled by one central module which only operates on the intermediate format. This module could be re`use`d for all formats. A possible intermediate format could be nested hashes `$cache = { ObjectType1 => { Param1 => 8, Param2 => "SomeText", NestedObject => { Param1 => 3, Param2 => "SomeText" } }` [download] Of course this highly depends on the nature of your data, like does order matter? are repeated elements allowed? Using nested arrays may be better then° And after transforming your data you can also have emitter modules to write them into a new out file. Like this you are even capable to transform between different formats, or add new ones. HTH! :) edit NB: this approach is also useful when handling only one input format, because you can cleanly separate code, hence much better maintain it. update °) or a mix of hashes and arrays. Or even using Perl objects blessing elements into different "ObjectTypes", ... Cheers Rolf _{(addicted to the Perl Programming Language :) Wikisyntax for the Monastery FootballPerl is like chess, only without the dice}	[reply] [d/l]

edit

edit

update