If you're looking for more of a tutorial approach to creating modules, have a look at [RFC] Discipulus's step by step tutorial on module creation with tests and git which is looking for feedback. Comments are positive, but it might benefit from the insight of someone actually using it in anger. It's the best way of finding out if there's something missing.