This is broken.

• This doesn't allow for multiple values in a query string (color=red&color=blue is perfectly legal).
• What happens if your $ENV{CONTENT_LENGTH} doesn't match the length of data read from STDIN: you get corrupted data, but you'll never know it.
• Newer clients are supposed to separate name/value pairs with semi-colons instead of ampersands. This will break your code.

As for the first bullet point, you might think that your code allows for multiple values, but it doesn't. If you have multiple values for one param name, you simply concatenate them. Consider the following:

color=red&color=blue

In your code, that results in:

$in{ 'color' } == 'redblue'
[download]

That's probably going to cause someone problems.

Hope you don't take this personally, and welcome to the Monastery! :)

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.