in reply to Problems with Net::FTP

Yeah, if you put your file list in an array like so: 
#!/usr/bin/perl -w
#
# Comments are allowed in both the file and host list if
# the comment row begins with a '#' sign.
# Entries in the file and host list should be seperated with
# a new row. spaces or other signs will make the script fail.
#
use Net::FTP;
use strict;

my $usage = "$0 filelist hostlist username password directory\n";
my $filelist = $ARGV[0] or die "$usage";
my $hostlist = $ARGV[1] or die "$usage";
my $username = $ARGV[2] or die "$usage";
my $password = $ARGV[3] or die "$usage";
my $home = $ARGV[4] or die "$usage";
my $debug = 5;

my $backupnode = undef;

open(FilesToGet, $filelist)
  or die "can't open filelist $filelist: $!\n";
my @FilesToGet = <FilesToGet>;
close FilesToGet;

open(HostsToGet, $hostlist)
  or die "can't open hostlist $hostlist: $!\n";

while (<HostsToGet>) {
    next if /#/;
    print STDERR "Connecting to $_" if $debug > 3;
    chomp;
    $backupnode = $_;

    for(@FilesToGet) {
        next if /#/;
        my $ftp = Net::FTP->new($backupnode);
        $ftp->login($username, $password);
        $ftp->cwd($home);
        print STDERR "Getting $_" if $debug > 3;
        chomp;
        $ftp->get($_,"$backupnode." . $_);
        $ftp->quit;
    }
}

[download]
it should be happier. Although you may want to add some code to make it skip files you grabbed... actually, $_ = '#'; at the bottom of the for loop would do that :)

                - Ant
                - Some of my best work - (1 2 3)

Replies are listed 'Best First'.
Re: Re: This should work.. i think
by enaco (Novice) on Nov 08, 2001 at 02:07 UTC

    Thanks mate.. but its already fixed and i almost did it all by myself *proud* 

    #!/usr/bin/perl
#
# Entries in the file and host list should be seperated with
# a new row. spaces or other signs will make the script fail.
# You can use comments if you put a '#' sign in front of the
# line, but it will make the printout of number of
# hosts/files that are beeing backuped to show the wrong numbers.
#
use Net::FTP;
use strict;

my $usage = "$0 filelist hostlist username password directory\n";
my $filelist = $ARGV[0] or die "$usage";
my $hostlist = $ARGV[1] or die "$usage";
my $username = $ARGV[2] or die "$usage";
my $password = $ARGV[3] or die "$usage";
my $home = $ARGV[4] or die "$usage";
my $debug = 5;
my @hostarr;
my @filearr;
my $nr = 0;

open(FilesToGet, $filelist)
  or die "can't open filelist $filelist: $!\n";

open(HostsToGet, $hostlist)
  or die "can't open hostlist $hostlist: $!\n";

@hostarr = <HostsToGet>;
chomp @hostarr;
my $hostarrnr = @hostarr;

@filearr = <FilesToGet>;
chomp @filearr;
my $filearrnr = @filearr;

print "\nHosts: $hostarrnr\n";
print "Files: " . ($filearrnr * $hostarrnr) . "\n";

print "\n";

for (my $nr1 = 0; $nr1 < $hostarrnr; $nr1++) {
    next if ($hostarr[$nr1] =~ /^#/ | undef);
    print STDERR "Connecting to $hostarr[$nr1]\n" if $debug > 3;
    my $ftp = Net::FTP->new($hostarr[$nr1]);
    $ftp->login($username, $password);
    $ftp->cwd($home);
    for (my $nr2 = 0; $nr2 < $filearrnr; $nr2++) {
        next if ($filearr[$nr2] =~ /^#/ | undef);
        print STDERR "Getting $filearr[$nr2]\n" if $debug > 3;
        $ftp->get($filearr[$nr2],("$hostarr[$nr1]." . $filearr[$nr2]))
+;
    }
    $ftp->quit;
}

    [download]
[reply]
[d/l]

In Section Seekers of Perl Wisdom