foreach $key (keys %Servers){
[download]

foreach my $key (keys %Servers){
[download]

Update: Though a good catch, this line:

$IP="$Server{$key}";
[download]

I agree about the foreach loop.

In addition, the actual error message (apparently) refers to the variable $IP as being undefined; this is because the assignment to $IP is using a different hash than the one that is being looped through. The loop starts with:

foreach $key(%Servers){
[download]

which loops through all of the key/value pairs of the hash %Servers in pseudo-random order (probably not what you wanted, as runrig has said). However, your assignment to $IP uses the variable $key to retrieve values from another hash called %Server, which is undoubtably empty, in fact making $IP undefined.

Also, as has been noted elsewhere, you most certainly do not need the double quotes around scalar values, for example, $Server{$key}: they force unnecessary interpolation, since $Server{$key} itself is already a string.

There is no particular reason to use a hash at all, preferring an array, which will preserve your ordering of IP addresses. I would go one step further and remove the unnecessary call to chomp (since the addresses do not end in newlines):

my @Servers = qw( 128.37.37.201
                  128.38.38.201
                  128.39.39.201 );

foreach my $IP ( @Servers ) {
  my $FTP = Net::FTP->new($IP);
  if ( $FTP->login($user,$pass) ) {
    $FTP->ascii();
    $FTP->put($File);
    $FTP->quit;
  }
  else {
    print "Error logging in to $IP: ". $FTP->message ."\n";
  }
}
[download]

dmm

You can give a man a fish and feed him for a day ...
Or, you can teach him to fish and feed him for a lifetime

I suspect the %Server vs. %Servers thing was a typo. His code sample shows him using strict, so an error like this should have been caught early on.

Good catch, though. I'd missed this one.

use strict;
use Net::FTP;

my $Local = 'c:\winnt\profiles\jlewis\desktop';
my $File  = "cron.file";
my ($user, $pass) = ("username", "password");

my @servers = qw/ 128.37.37.201 128.38.38.201 128.39.39.201 /;

chdir($Local) or die "$Local: $!";

foreach (@servers) {
  my $FTP = new Net::FTP ($_) or die "Can't connect to $_";
  $FTP->login($user, $pass) or die "Can't login as $user"
  $FTP->ascii;
  $FTP->put($File) or die "Can't put $File"
  $FTP->quit;
}
[download]

The warning about the uninitialized value came about because you were doing this: $IP="$Server{$key}" Since $key at one point was "128.37.37.201", you were trying stuff the value of that key in the hash into $IP. Since there was no key by that name (it was a value, remember), the result was undefined, hence that warning.

Hope this helps..

$IP="$Server{$key}";
[download]

$IP=$server{$key};
[download]

perldoc -q quoting

to the many nuggets of wisdom in the thread, let me add the almost cliche:

use strict;
[download]

Update