in reply to Seeking Feed Back on a Game

My first step would be to run perltidy on this script and actually get some indentation.

My second piece of advice is to break out more functions. A good rule of thumb is that if a function or block of straight code goes over 50 lines, you probably are doing something wrong. This is not always true, but it is true enough that it is worth asking yourself why the function is getting long.

A third piece of advice is that the logic about how your stock names relate to the array of values is entirely maintained in your code. This makes understanding your data structures much harder, and makes your code more fragile. Insert usual advice about using a hash, and using some looping logic. (Which would also remove a lot of repeated code.)

(These items significantly affect how easy your code is to follow, and how complex of programming tasks you can tackle.)

  • Comment on Re (tilly) 1: Seeking Feed Back on a Game