A few things:

First off, use the File::Find module to recursively plow through directories. It is MUCH easier to work with than rolling your own script, and comes bundled with every version of perl.

Secondly, use strict and -w. They will help you write clean code, catch typos, and make your life easier.

Thirdly, on to your problem. I've rewritten your code to this: (using File::Find, strict, and -w)

#!perl -w
use strict;
use File::Find;

my $path = $ARGV[0];
my $ct = 0;
find (\&wanted, $path);
print "Number of files changed: ", $ct, "\n";

sub wanted
{
  if ($_ ne lc($_)) 
  {
     my $newname = lc($_);
     rename ($File::Find::name, $File::Find::dir . $newname);
     print $_, " was changed to ", $newname, "\n";
     $ct++;
  }
}
[download]

If you have any questions about the above code, please reply so that we can clear up any everything.

I believe you are right about the -d $fname thing, try this:

  if ( -d "$path/$fname" ) {
[download]

Also, on a nit-picky note, if you have really big directories, it is more efficient to do a readdir one at a time then to slurp it all into an array

  opendir(DIR, $path);
  @files = readdir(DIR);

  $ct = 0;
  while ($fname = readdir(DIR)) {
  
   ... # Damian Conway's 'yada, yada, yada' operator :)

  }
  closedir(DIR);
[download]

Addendum: The same reason that your -d test is not working applies to your renaming problem. As you can see from your output, readdir doesn't return the path, only the filename. You'll probably need to include full paths with your rename() args.

... # Damian Conway's 'yada, yada, yada' operator :)

And it's not just wishful thinking anymore:

http://search.cpan.org/search?mode=module&query=yada%3A%3Ayada

;-)

++ehdonhon !!

When using readdir(), it is necessary to prefix each item read with the $path passed to opendir().

Also, notice the backticks (backquotes?) in:

  if(`-d $fname`)
[download]

which (if not a typo in JoeCool's original code) effectively send the -d $fname as a command to the shell. Probably not what he intended.

dmm

You can give a man a fish and feed him for a day ...
Or, you can teach him to fish and feed him for a lifetime

#!d:/perl/bin/perl -w

use File::Find;
use strict;

find ({
    'wanted'    =>  \&renamefile,
}, '/path/to/sub/directory');

sub renamefile {
    my ($dev, $ino, $mode, $nlink, $uid, $gid);
    return unless (($dev, $ino, $mode, $nlink, $uid, $gid) = lstat($_)
+);
    rename $_, lc($_);
}
[download]

perl -e 's&&rob@cowsnet.com.au&&&split/[@.]/&&s&.com.&_&&&print'

That should read

    rename $_, lc($_) or warn "Could not rename $_ to @{[lc($_)]}: $!\
+n";
[download]

In case the target filename already exists in the directory (especially if case-sensitive filesystems are involved). Or warn instead of die. Or break lc($_) out into a variable to avoid the code interpolation. Whatever.

--

g r i n d e r
just another bofh

print@_{sort keys %_},$/if%_=split//,'= & *a?b:e\f/h^h!j+n,o@o;r$s-t%t#u';

Excellent point grinder++ ... Thanks for the pick-up

 

perl -e 's&&rob@cowsnet.com.au&&&split/[@.]/&&s&.com.&_&&&print'