You are correct the strncpy is superfluous. The string terminator is missing but newSVpv() has been called with an explicit length so it doesn't matter.

All in all I would prefer jcwren's methodology.

--
John (wishes there was a C-monks).