in reply to Critique / Suggestions?

That's decent code as it is. I can help with the range, though, if I'm reading it correctly. Try this:
for my $aref (@$STF3) { print OUTPUT qq|<li>$aref->[0] </li><a href="$aref->[1}$STF3_Table +s">$aref->[2]</a><br />\n|; }
You could even throw printf in there, if you were so inclined.

Stylisticly, you can give a list of variables to my, and you usually don't need to initialize them explicitly. I generally say my ($foo, $bar, @baz, %kudra);.

You can also get rid of temporaries, like so:

return split(/\n/, $document); return \@STF1, \@STF3;
It also wouldn't hurt to select the OUTPUT filehandle. The only thing I'd ding you for on a code review would be the loops, and that's because you're only hurting yourself there. :)

Replies are listed 'Best First'.
Re: Re: Critique / Suggestions?
by Sang (Acolyte) on Jan 05, 2002 at 13:34 UTC
    Great comments, used every single one so far. I'm ecstatic to have that nasty for loop looking decent. The format I was using for it was based off one in "The Perl Cookbook" for printing all the elements of a multi-dimensional array, and used $#LoL to define the upper range, but when I switched stuff into subroutines and started passing refs I couldn't figure out anything other than what I had.

    Appreciate the help everyone on this site has offered, between it and the sheer quantity and quality of the docs perl has won yet another convert!