in reply to Critique / Suggestions?
You could even throw printf in there, if you were so inclined.for my $aref (@$STF3) { print OUTPUT qq|<li>$aref->[0] </li><a href="$aref->[1}$STF3_Table +s">$aref->[2]</a><br />\n|; }
Stylisticly, you can give a list of variables to my, and you usually don't need to initialize them explicitly. I generally say my ($foo, $bar, @baz, %kudra);.
You can also get rid of temporaries, like so:
It also wouldn't hurt to select the OUTPUT filehandle. The only thing I'd ding you for on a code review would be the loops, and that's because you're only hurting yourself there. :)return split(/\n/, $document); return \@STF1, \@STF3;
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Re: Critique / Suggestions?
by Sang (Acolyte) on Jan 05, 2002 at 13:34 UTC |