in reply to For Review: DB Import

Hmmm...I like it.

Your comments just say what the code is doing. I always like to include why.

Little comments (like at the end when you disconnect from the database) just seem superflous when there's no documentation for your while( <INPUT> ) loop at all. Dont get me wrong though! Comments are a Good Thing (tm)

I think that s/\"//g; can be re-written (more efficently?) using tr

-- Dave

Replies are listed 'Best First'.
Re: Re: For Review: DB Import
by impossiblerobot (Deacon) on Jan 25, 2002 at 21:43 UTC
    Thanks, spaz. I will look over the comments and see if I can emphasize the why.

    Many of the what comments are a result of my coding style. I usually tend to write the entire program as comments, then fill in the actual code. I probably knocked out some of the original comments in the process of restructuring.

    I agree that tr/// would be better than s///. (I'm not sure why I escaped the quote in the first place!)

    Impossible Robot
[reply]

In Section Seekers of Perl Wisdom