Re: Display all images in a given directory

Some random points:

Why assign "0" to $count instead of 0?
grep is your friend: my @files = grep { /\.(?:png|gif|jpg)$/ } readdir DIR;
Why use CGI's HTML code, but then don't use it to write the images?

gav^

Comment on Re: Display all images in a given directory Download Code

Replies are listed 'Best First'.
Re: Re: Display all images in a given directory by cjf (Parson) on Feb 02, 2002 at 04:22 UTC
Thanks for the pointers :) I like your grep method far better. As for using the one here document I did that because I thought there were problems with quotes if I use the CGI.pm `print $q->p("")` method. In hindsight I'm sure there is a way around this (do I even need the quotes in the cgi print method?). Update jarich pointed out a nice way to use CGI.pm to to print out the paragraphs. I've included that in the code now.	[reply] [d/l]

Replies are listed 'Best First'.

Re: Re: Display all images in a given directory
by cjf (Parson) on Feb 02, 2002 at 04:22 UTC

I like your grep method far better. As for using the one here document I did that because I thought there were problems with quotes if I use the CGI.pm print $q->p("") method. In hindsight I'm sure there is a way around this (do I even need the quotes in the cgi print method?).

Update jarich pointed out a nice way to use CGI.pm to to print out the paragraphs. I've included that in the code now.

[reply]
[d/l]