rdfield

update and change opendir to open

Many thanks for all the assistance! It now works. I needed the * to make it work as you suggested:

@files = glob('/perl/bin/dir/*');
[download]

I think you are going to have explain what it is you are trying to do here, because it isn't entirely clear from your code.

If all you want to do is edit all of the files in the directory /perl/bin/dir then you can just do:

  perl -pi.bak 's/<meta name="/<meta name="area./gi' perl/bin/dir/*
[download]

In the code that you have the glob() will only return one value (ie./perl/bin/dir) and then you appear to get confused about what opendir does.

If you want to do this in longer code rather than a one-liner then you might try something like:

#!/usr/bin/perl -w

use strict;
use Fcntl qw(:seek);
my $dir = './dir';

opendir(DIR,$dir) || die "Can't open $dir - $!\n";


my @files = map { "$dir/$_" } grep !/^\.{1,2}$/, readdir(DIR);
closedir DIR;

foreach my $file (@files)
{
   open(FILE, "+<$file") || die "Can't open $file - $!\n";

   my $contents = do { local $/; <FILE> };

   $contents =~ s/<meta name="/<meta name="area./gis;

   truncate(FILE,0) || die "truncate - $file : $!\n";;
   seek( FILE,SEEK_SET,0) || die "seek - $file : $!\n";
   print FILE $contents;
   close FILE;

}
[download]

/J\

Thanks for the additional info. Now everything works. Reference your script I would like to learn more about how it works. Can you please explain what is going on in this script? I am not familiar with this part:

  my @files = map { "$dir/$_" } grep !/^\.{1,2}$/, readdir(DIR);
[download]

And I need some guidance on what the script is doing here:

truncate(FILE,0) || die "truncate - $file : $!\n";;
     seek( FILE,SEEK_SET,0) || die "seek - $file : $!\n";
[download]

Thanks!

I can't quite see what you're doing, but I can point out a few errors.

• Indent your code
• Use strict warnings and diagnostics or die
• Use closedir() to close a directory handle opened with opendir()

Cheers.

BazB.

Update: Looks like rdfield and dws have it cracked.
Looks like the use of opendir() was incorrect.
I'll leave this node here, since the advice is still valid.