Derby, I am using raise error, as for prepare I just thought that it gave the database a chance to optimise the query and get ready for action. I tried it woith do instead of prepare and got can't call do on undefined value. I put in my $dbh=$self->param('dbh') or die 'it is undef'; and it did't die

MZSanford the db handle is defined cos I use it elsewhere. Weird thing is I am getting the erro even though my program does not even call the sub anywhere.

cheers
UPDATE Problem solved, I am using CGI::Application which has a method called query, calling my subroutine 'query' has caused this rather unhelpful error. Thanks for the tips anyway, maybe I should have mentioned CGI::application to begin with. A failed unintentional attempt at method overriding ha:)