in reply to RFC: RPC_OO.pm

package RPC_OO;

This is not a CPAN-worthy script (yet), because it has very bad error handling (if any). Referencing a global special scalar ($@ here) is probably not a very good idea. There are two kinds of false wantarrays, namely defined and undefined - you should think about handling them both.

RPC_OO is a bad package name, because it's top-level, and there already are a lot of RPC modules in the RPC:: namespace. _IF_ (and I think you really should not) you decide to put this on CPAN, at least rename it to RPC::OO.

And all modules should have detailed documentation, of course!

I haven't used RPC in any way, but I think it needs to be easy to use. That is, I think you should know only a line or five to get it running, and not have to copy/paste a given synopsis. 

U28geW91IGNhbiBhbGwgcm90MTMgY
W5kIHBhY2soKS4gQnV0IGRvIHlvdS
ByZWNvZ25pc2UgQmFzZTY0IHdoZW4
geW91IHNlZSBpdD8gIC0tIEp1ZXJk

Replies are listed 'Best First'.
Re: Re: RFC: RPC_OO.pm
by Necos (Friar) on Mar 18, 2002 at 11:29 UTC
    Thanks for the constructive criticism. I've already talked with a few monks about rewriting the code for this module once I have the time to do so. I've been going over a few very nice error handling routines in my head that I think would work well with the code (of course, it's kind of mean to look into someone's message). Chances are, when I put this little RPC module up for comments again, it will be named something completely different (like RPC::OO, which you suggested... or something more exotic, like Net::RPC).

    Ironically enough, I was told that RPC could be done via SOAP and POE, but this was something I had been planning on doing (just to see if I could) for a long time. Thanks to all the folks around here at the Monastery that put up with my fits of madness. For the time being, this module will run in my production code for thorough testing before I begin rewrites of code. Maybe someday this code will become CPAN worthy. Only time will tell...

    Theodore Charles III
    Network Administrator
    Los Angeles Senior High
    4650 W. Olympic Blvd.
    Los Angeles, CA 90019
    323-937-3210 ext. 224
    email->secon_kun@hotmail.com
[reply]

In Section Meditations