Re: Directory Listing to an Array

I'd scope the variables and what-not; also, you're doing far more work than necessary.

sub ls {
  my $path = @_ ? shift : ".";
  local *DIR;
  opendir DIR, $path or die "can't ls $path: $!";
  return grep { $_ ne "." and $_ ne ".." } readdir DIR;
}
[download]

_____________________________________________________
Jeff[japhy]Pinyan: Perl, regex, and perl hacker, who'd like a (from-home) job
s++=END;++y(;-P)}y js++=;shajsj<++y(p-q)}?print:??;

Comment on Re: Directory Listing to an Array Download Code

Replies are listed 'Best First'.
Re: Re: Directory Listing to an Array by cybear (Monk) on Apr 17, 2002 at 14:56 UTC
what does the `shift : "."` do?	[reply] [d/l]
Re: Re: Re: Directory Listing to an Array by japhy (Canon) on Apr 17, 2002 at 15:13 UTC
The `?:` operator is like a condensed if/else block. `my $path; # if an argument was passed, use it if (@_) { $path = shift } # otherwise, use "." else { $path = "." }` [download] That can be written as `my $path = @_ ? shift : ".";` -- and if I wanted to be even shiftier (pun intended), I could do `my ($path) = (@_, ".");` but that's probably rude. _____________________________________________________ Jeff`[japhy]`Pinyan: Perl, regex, and perl hacker, who'd like a (from-home) job `s++=END;++y(;-P)}y js++=;shajsj<++y(p-q)}?print:??;`	[reply] [d/l] [select]