First of all, this does NOT replace crlf pairs with </p><p>. Period. Second of all, there is a buffer overflow as you malloc(2*strlen(str)). Please pass your routine "1\r2\r3\r" and see how it will give you a nice SEGFAULT (which you might not even see since you're ona Win98 box).