If the file is created, then it means we've got this far:

  if($photo ne '') {
    $photodir = ">../../listing/$ident-$fr{listingid}-$i.jpg&q
+uot;;
    $fh = $q->upload("photo$i");
    open(PFILE, $photodir);
    while(<$fh>) { print PFILE; }
    close(PFILE);
  }
[download]

In fact we've got as far as opening the file and that's all worked OK.

This thing is so stuffed with variables that only you understand, I think what I'd do is have all my variables printed out on screen so I could check they were doing what I thought they were doing, like, I'd put:

print "I'm now trying to open /listing/$ident-$fr{listingid}-$i.jpg"

at each step, just so I'd get a confirmation of what was being called.

Clunky but it works for me.
--

($_='jjjuuusssttt annootthheer
     pppeeerrrlll haaaccckkeer')=~y/a-z//s;print;
[download]