Re: confused

Personally, I would have written your code as follows: (UNTESTED !!!)

#!/usr/local/bin/perl -w
use strict;

my $params=@ARGV;
my ($input,$output,$length);

if($params < 3){
  die "Not enough parameters";
}else{
  ($input,$output,$length)= @ARGV;
}

open(INFILE,"$input")||die "Can't open $input: $!\n";
open(OUTFILE,">$output")||die "Can't open $output: $!\n";

my $count=1;

while(<INFILE>){
  chomp;
  if(/>/){ ++$count; }
  if(length($_) >= $length){
    print "\>$count\n",$line,"\n\n";
    print OUTFILE "\>$count\n",$line,"\n\n";
  }
}

close INFILE;
close OUTFILE;
[download]

UPDATE:Changed code per Biker's suggestion. And what is really sad, is that I actually had it right the first time, and changed it. :-(

TStanley
--------
Never underestimate the power of very stupid people in large groups -- Anonymous

Comment on Re: confused Download Code

Replies are listed 'Best First'.
Re: Re: confused by Biker (Priest) on May 15, 2002 at 15:20 UTC
I believe this line: `($input,$output,$length)= shift @ARGV;` [download] should read: `($input,$output,$length)= @ARGV;` [download] Everything went worng, just as foreseen.	[reply] [d/l] [select]
Re: Re: confused by davorg (Chancellor) on May 15, 2002 at 15:26 UTC
If it was my script, I'd write it like this: `#! /usr/local/bin/perl -w use strict; die "Not enough params!!!\n" if @ARGV < 3; my ($input, $output, $length) = @ARGV; open INPUT, $input or die "unable to open $input: $!\n"; open OUTFILE, ">$output" or die "unable to open $output: $!\n"; my $count = 1; while (<INPUT>) { chomp; ++$count if />/; if (length >= $length) print ">$count\n$_\n\n"; print OUTFILE ">$count\n$_\n\n"; } } close INPUT; close OUTFILE;` [download] -- <http://www.dave.org.uk> "The first rule of Perl club is you do not talk about Perl club." -- Chip Salzenberg	[reply] [d/l]