in reply to Associative Array Trouble

Update: You have a terrible error that's one of my hobbyhorses, and I missed it on the first cut :( $a is sacred to sort

You're assigning a whole new %list each time around.

while(<TEST>){
    chomp;
    /(\w+)\s+(\w+)/;
    print "$i : $2\,$1\n";
    $list{$i} = [$1,$2];
    $i+=1;
}

[download]
Also, when you want the values, you need to should dereference:
foreach my $c (sort keys %list) {
    print "$list{$c}->[1],$list{$c}->[0]$/"
}

[download]
That should fix things up.

Update: Softened statement on dereferencing and corrected horrible error mixing $a as temporary with sort.

Update 2: Here's a line to sort and print all at once

print map {"$_->[1], $_->[0]$/"} sort {lc($a->[1]) cmp lc($b->[1])} va
+lues %list;

[download]
You might also consider split instead of re+backreferences for parsing your data, more efficient. Edit, corrected typo of dropped paren

After Compline,
Zaxo

Replies are listed 'Best First'.
Re: Re: Associative Array Trouble
by EmmittSmith (Acolyte) on May 23, 2002 at 00:05 UTC
    Thank's, that worked well, except it doesn't display the last names alphabetically... I'm not quite sure what the problem is--I think it may have to do something with the keys being numbers, and we are telling it to sort by them. This is my first time using associatve arrays, so bare with me :P...anyway here's the new code:

    #!/usr/bin/perl -w 

use strict;

open(TEST, 'test.txt') || die "Couldn't open it";
print "\nFile Opened\n\n\n";
my $i=1;
my %list;
while(<TEST>){
    chomp;
    /(\w+)\s+(\w+)/;
    print "$i : $2\,$1\n";
    $list{$i} = [$1,$2];
    $i+=1;
}

foreach my $c (sort keys %list) {
    print "$list{$c}->[1],$list{$c}->[0]$/"}



close(TEST);
die "\n\n\nFile Closed\n";

    [download]

    Input file:

    Emmitt Smith
Walter Payton
Barry Sanders
Jim Brown
Jeremy Smith

    Oh yeah, what do you mean by dereferencing?

    Thanks,
    Emmitt

[reply]
[d/l]
      Your second take is much better, much more indented, but try and keep things neat. Your closing brace in your foreach, for example, is strangely at the end of a line which is also sans-semicolon.

      Anyway, to "derefence" something is to take a reference and use it to obtain a value. References are what make people exposed to C for the first time look all green and dizzy, but they're really not that bad, especially in Perl.

      Here's a really, really brief introduction to references: 
      my @array      = qw[ 1 2 3 ];
my $array_ref  = \@array;      # Backslash makes a reference
my @array_copy = @$array_ref;  # @ de-references array reference

$array[2]       = 4;   # Modifies @array directly
print $array_ref->[2]; # Should be '4' now
$array_ref->[1] = 5;   # Modifies @array by reference
print $array[1];       # Should be '5'
$array_copy[1]  = 6;   # Modifies @array_copy, not @array
print $array[1];       # Still '5'

      [download]
      For a much more detailed document, check out perlref.

      Fortunately, or unfortunately depending on your opinion, Perl will automagically dereference for you in certain circumstances. Where $foo->{bar} is actually an "ARRAY" reference, you should really sub-address that as $foo->{bar}->[1] and not $foo->{bar}[1], but either should work.
[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom