First, a comment on your coding style .. it seems that you have declared a whack of variables that get set elsewhere (so we're missing the code that sets $article_title, $article_id). You're also passing these global variables into the subroutine edit_news in your mainline, but you don't catch those variables as parameters in the subroutine itself. I suggest you pick one style and stick with it -- globals or parameters (hint: parameters are far more preferable to globals).

My preference is always to put the mainline inside braces to make it clearer what's going on. In addition, the conditionals you havein your mainline could be organized a little better:

  if ( $vars { action } )
  {
    if ( $vars{action} eq "news" )
    {
      &news if (!$vars{article});
      &show_news if ($vars{article} || $vars{editnews});
    }
    elsif ( $vars{action} eq "editnews" )
    {
      &edit_news($article_title, $article_body);
    }
  }
  else
  {
    &left_content();
    &right_content();
  }
[download]

Second .. what SQL is being generated? Are you sure that it's correct? Perhaps try turning on DBI->trace to see what DBI is doing.

--t. alex

"Nyahhh (munch, munch) What's up, Doc?" --Bugs Bunny

Update Fixed some typos.