Note - I've assumed here that &error returns and 'email2' is the second email field.

my @required = qw(name site siteid email email2 pass repass);

my $req_err;
for (@required) {
  next if $q->param($_);
  $req_err++; last;
}
if ($req_err) {
  &error("You forgot some required fields"); 
}
elsif ($q->param('email') ne $q->param('email2')) {
  &error("The two e-mail addresses you entered don't match"); 
}
elsif($q->param('pass') ne $q->param('repass')) {
  &error("Your passwords don't match");
 }
else {
  # do whatever...
}
[download]

$q->param('siteid') =~ /^\s*(\d+)\s*$/
my $site_id = $1

if ($site_id) {
  if (-d '/path/to/sites/'.$site_id) {
    &error("Directory already exists");
  }
  else {
    # directory doesn't exist, so do whatever...
  }
}
else {
  &error("Invalid Site ID");
}
[download]

my @required = qw(name site siteid email email2 pass repass);

for (@required) {
  next if $q->param($_);
  &error("You forgot some required fields"); 
}

$q->param('email') eq $q->param('email2') 
  or &error("The two e-mail addresses you entered don't match"); 

$q->param('pass') eq $q->param('repass')
  or &error("Your passwords don't match");

my ($site_id) = $q->param('siteid') =~ /^\s*(\d+)\s*$/;

$site_id or &error("Invalid Site ID");

-d '/path/to/sites/'.$site_id
  or  &error("Directory already exists");

# directory doesn't exist, so do whatever...
[download]

cLive ;-)

--
seek(JOB,$$LA,0);

my @required = qw(name site siteid email email2 pass repass);
my ($site_id) = $q->param('siteid');
my $req_err;
for (@required) {
  next if $q->param($_);
  $req_err++; last;
}
if ($req_err) {
  &error("You forgot some required fields");
}
elsif ($q->param('email') ne $q->param('email2')) {
  &error("The two e-mail addresses you entered don't match");
}
elsif($q->param('pass') ne $q->param('repass')) {
  &error("Your passwords don't match");
 }
elsif (-d "/var/www/virtual/webewebin.com/home/$site_id") {
    &error("Directory already exists");
}
else {
}
[download]


That worked just fine, if I would of done this


$q->param('siteid') =~ /^\s*(\d+)\s*$/;
[download]


Then it says everysite id exists, if I would of just did


my ($site_id) = $q->param('siteid');
[download]


It would work fine

Where are the directories you want to check against? Are you checking for them locally, or are you looking to see if there's a match with one of the elements of your array @directory? You can do the first check with -e and the second using a foreach to loop through each of the elements and test for equality.

I also notice that your E-Mail test would fail with any domain that has more than two parts .. better would be

  /^\S+@\S+(\.\S+){1,}/
[download]

--t. alex

"Nyahhh (munch, munch) What's up, Doc?" --Bugs Bunny

> I also notice that your E-Mail test would fail with any domain that has more than two parts ..
Wrong, it would match because there is no anchor at the and of the regex. But the test is really bad anyway ...

> Suffice to say that it's impossible to write a regexp that parses E-Mail addresses.
See Jeffrey Friedl's regex that checks if an email address conforms to rfc822 published in Mastering Regular Expressions. IIRC that regex is about 6k characters long, it is also included in the module Email::Valid which I would recommend for checking email addresses.

cheers,
snowcrash

> Suffice to say that it's impossible to write a regexp that parses E-Mail addresses.
See Jeffrey Friedl's regex that checks if an email address conforms to rfc822 published in Mastering Regular Expressions. IIRC that regex is about 6k characters long, it is also included in the module Email::Valid which I would recommend for checking email addresses.
Right, well of course, what I was implying was that it's impossible to write a *short* regexp that will accurately parse for a valid E-Mail address. Anything's impossible with enough code and horsepower to run it.

I still maintain that in the context (code size, inferred experience level) of the original message, such a regexp is impossible.

--t. alex

"Nyahhh (munch, munch) What's up, Doc?" --Bugs Bunny

# Untested
elsif ( !stat( $q->param( 'pass' ) ) )
{
    # do something
}
[download]

If you mean you have a vector of domain names stuffed in a directory, you can (lazily) do something like:

 my $siteid=$q->param('siteid');
 if(!$siteid) {
   #complain
  } elsif(grep {$siteid eq $_} @directory) {
    # taken
  } else {
    mkdir 0755 $siteid or warn("Foo: $!")
    push @directory, $siteid;
    # or whatever
  }
[download]

Cheers,
alf