Re: First steps in OO-Perl , suggestions please!

Here's a bunch of points that sprung to mind from looking over the code

Lower-case package names indicate pragmata, so your package might be better named MyFTP
You've got the cargo-cult ref($proto) || $proto which, like all code, you shouldn't use unless you know what it it's doing (see. this node for some heavy discussion on the matter)
There's an awful lot going on in your constructor which should probably be fielded off to an initialisation metehod
While I realise you've left out comments for a reason it would be very much more perlish to change the comments at the top of the source into POD :)
In your put(), get() and delete() methods you should be returning the status of the equivalent Net::FTP call
You could cut down on duplicate code by getting rid of the double bare blocks in some of the methods as they currently don't serve a great deal of purpose
The method grep_size() is a package level sub, so it's a good idea to move it into the same code space (unless you want to use Sub::Lexical ;)
And one more minor point - your lines are positively mahoosive. It'd be nice if they were nearer the 80-char 'standard', but different keystrokes for different folks I guess

Of course perl is all about TIMTOWTDI and if it ain't broke don't fix it. But if you're serious about getting OO in perl down then I'd recommend checking out other OO languages, not only will you get a feeling for how OO works you'll also appreciate the freedom you get from perl's OO system.
HTH

_________ broquaint

Comment on Re: First steps in OO-Perl , suggestions please!

Replies are listed 'Best First'.
Re: Re: First steps in OO-Perl , suggestions please! by kodo (Hermit) on Jul 25, 2002 at 13:29 UTC
Well to be honest I didn't think much about using `ref($proto) \|\| $proto`, I did because I've read Planning for the Future - Better constructors in perltoot. Yes I'll do a POD once it's really finished About the 80-char-standard: Should I just break the lines? All other points: Agreed. :) thanks! giant	[reply] [d/l]
Re: Re: Re: First steps in OO-Perl , suggestions please! by broquaint (Abbot) on Jul 25, 2002 at 13:48 UTC
About the 80-char-standard: Should I just break the lines? Break the lines where it's logical. For example when you assign the new `Net::FTP` object to `$self->{ftp}` you could restructure it like so `$self->{ftp} = Net::FTP->new( $self->{'host'}, Port => $self->{'port'}, Timeout => $self->{'timeout'}, Debug => $self->{'debug'} ); unless($self->{ftp}) { ... }` [download] Play around with it and see what looks best to you. You might even notice some improvements that could be made to your code along the way. HTH `_________ broquaint`	[reply] [d/l]