in reply to First steps in OO-Perl , suggestions please!

You've got:

$SIG{__WARN__} = sub { push(@{ $self->{'sub_warnings'} }, shift); 
+} if $self->{'verbose'} == 0

[download]

in your new() method. I wouldn't recommend doing that, or you'll be left wondering why you're warn statements in the calling script aren't acting as expected. You should be very careful when setting the special globals in order to avoid unwanted action at a distance.

cephas

Replies are listed 'Best First'.
Re: Re: First steps in OO-Perl , suggestions please!
by kodo (Hermit) on Jul 25, 2002 at 14:46 UTC
    Um well I wanted it that way, get all warnings in that array and print it with stats() then at the end.

    giant
[reply]
      You asked for advice on OO. If you're going to encapsulate functionality, you should not affect things outside the scope of your module. By setting a handler for all warn calls the way you have done, all of the warning messages that might be generated by the script using your module would also be trapped. It may be what you want in your scenario, but if I personally were to use a module and suddenly have all of my calls to warn() stop working as expected, I would at first be confused, then annoyed once I found out what the problem was and had to rewrite my code to account for this. The only time I could see that you would want to rewrite the warn handler on a global scale would be if you were writing a message specificly for the purpose of trapping warn messages.

      Just my 2 cents.

      cephas
[reply]
        Okay, true. My thought was that I have verbose 1 as default, and if it's wanted 0 so that nothing is shown in STDOUT. But you are right, there maybe better ways to solve this, I just thought you maybe thought that this happened without a specific reason so I wanted to clearify that.
        Thanks!

        giant
[reply]

In Section Seekers of Perl Wisdom