Re: Re: Passing hashes to subs?

&callsub(%hashtopass); sub callsub { %hashread = @_;
[download]

I don't think this is good practice.. what if you decide to pass a scalar along with that and forgot to shift it out before assigning the list to the hash? you might end up with a corrupted list, or worst, a legitimate list with wrong values shooting yourself in the foot.

He who asks will be a fool for five minutes, but he who doesn't ask will remain a fool for life.

Chady | http://chady.net/

Comment on Re: Re: Passing hashes to subs? Download Code

Replies are listed 'Best First'.
Re: Passing hashes to subs? by crenz (Priest) on Aug 01, 2002 at 12:46 UTC
Yes, that's why I suggested the second approach using references. But I neglected to point out the dangers to the original poster. Thanks! FWIW, I do like to use it if (and only if...) the function is designed to receive only named parameters. E. g. `sub create { my $self = shift; my %p = @_; print "$p{color} p{animal}" for (1..$p{count}); } $zoo->create(animal => 'camel', count => '10', color => 'green');` [download] One could opt to create the zoo using a hash reference as in `$zoo->create({animal => 'monkey', ...});` but I guess that is a matter of style.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: Passing hashes to subs?
by crenz (Priest) on Aug 01, 2002 at 12:46 UTC

Yes, that's why I suggested the second approach using references. But I neglected to point out the dangers to the original poster. Thanks!

FWIW, I do like to use it if (and only if...) the function is designed to receive only named parameters. E. g.

sub create {
    my $self = shift;
    my %p = @_;
    
    print "$p{color} p{animal}" for (1..$p{count});
}

$zoo->create(animal => 'camel',
             count  => '10',
             color  => 'green');
[download]

One could opt to create the zoo using a hash reference as in

$zoo->create({animal => 'monkey', ...});

but I guess that is a matter of style.

[reply]
[d/l]
[select]