I suppose the only reason to have the logic inside the regex is the case addressed by the (?(condition)yes-pattern|no-pattern) construct, namely where there is additional matching to be done which is dependant on the outcome of the test. In my example there was no such dependency so as you noted it makes sense for the logic to be external to the regex.

Thanks for helping me figure this out!

Josh