in reply to Re: Re: Re: Re: OOP - Sharing class methods
in thread OOP - Sharing class methods

The problem there is that you've hardwired the Utility class's name into your class. Suppose you want to subclass Foo to use a different UtilityClass (or a subclass of it), with the hardwiring you have in place you have to override all the methods that make calls to the utility class.

At the very least you should wrap the Utility classname in a method, so your code becomes: 

package Foo;
use UtilityClass;

sub helper { 'UtilityClass' }

sub bubbles {
   ...
   $self->helper->buttercup();
   ...
}

[download]
Et voila! you'll only have to change the utility class name at two points in your subclass; no need to override.

Actually, I wonder if you couldn't use the Exporter to implement something like a ruby mixin. 

package UtilityClass;

use base 'Exporter';

@EXPORT = qw/buttercup/;

sub buttercup {
   my $self = shift; # $self is *not* a 'UtilityClass';
   ...
}

[download]
You know, I'm not sure whether that's a good idea, or a barking mad one...

Replies are listed 'Best First'.
hard-coding class names
by perrin (Chancellor) on Aug 15, 2002 at 22:11 UTC
    Suppose you want to subclass Foo to use a different UtilityClass

    Well, if that happened, and there was nothing else in the subclass that would cause me to override these methods, then I would do what you've suggested. However, that's a pretty unlikely scenario and I don't see any reason to add the extra complexity until it's actually needed. My opinion is that the code should stay as simple as possible until the requirements demand it be more complex.

    I've also seen this sort of technique used for runtime configuration (e.g. use Storable or Data::Dumper for serialization), but that doesn't seem to be called for here.

[reply]
      Ah. I must confess that I don't really think of the first of those methods as adding complexity so much as reducing repetition and adding simplicity. I've got caught out by hardcoded class names in projects before so now it's almost a reflex to fetch them dynamically.

      Actually, my usual issue with hardcoded classnames is that it makes using 'mock object' techniques that much harder, but the very lovely Test::MockObject makes working 'round that particular issue a lot easier now.

[reply]

In Section Seekers of Perl Wisdom