in reply to Module Design Review - Exporter::VA
Excellent! Here are my mostly minor comments.
s/sence/sense/, s/\$EXPORT/@EXPORT/, and you need to quote many of your hash keys since things like .foo and &foo are not barewords.
The function must return a reference to the proper type of thing, which is what will be placed in the caller's package.
I'd allow for callbacks to return undef to indicate that there is nothing to import so that modules can have non-importing options that use plain names.
Version strings are going away. You should not be using them in a new module.
- tye
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: (tye)Re: Module Design Review - Exporter::VA
by John M. Dlugosz (Monsignor) on Oct 29, 2002 at 15:48 UTC | |
by tye (Sage) on Oct 29, 2002 at 16:06 UTC | |
by John M. Dlugosz (Monsignor) on Oct 29, 2002 at 20:40 UTC | |
by John M. Dlugosz (Monsignor) on Oct 29, 2002 at 17:12 UTC | |
by Aristotle (Chancellor) on Oct 29, 2002 at 22:26 UTC |