in reply to Matching an IP address
What you have is fine, though you could take more advantage of /x to clean up the regex:
If you know the number of spaces around "->", use it instead of \s* (e.g., "\s->\s" instead of "\s*->\s*").if ( $line =~ m{ ^\s* ( # begin client IP \d+\.\d+\.\d+\.\d+ ) :\d+ # client port (ignored) \s*->\s* ( # begin vips \d+\.\d+\.\d+\.\d+ ) :\d+ # vips port (ignored) \s*->\s* ( # begin frontend \d+\.\d+\.\d+\.\d+ ) }x ) { $client_ip{$1}{$iteration}++; $vips{$2}{$iteration}++; $frontend{$3}{$iteration}++; }
If you've got a lot of data, you're probably not going to want to pull it all into @connections. That's gotta suck up RAM.
Also, consider inverting the data structure you're collecting the counts in. If $iteration is relatively fixed (i.e., changes slowly, compared to the number of connections you're processing), you might save significant time by taking counts without considering $iteration, then sweep those counts into a larger data structure whenever $iteration changes. This is one to benchmark, since it could easily backfire depending on your data mix.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Re: Regex redux
by ibanix (Hermit) on Nov 19, 2002 at 20:55 UTC |