in reply to Re: Assigning Opsets by User Type
in thread Assigning Opsets by User Type
Thanks Abigail. @usertypes should be okay due to checks in the module from which it comes, although I'll have to audit that code to make sure. The sorting bit now does a sort { $a <=> $b }.
The order in which the keys are put in %attr_value is messy. Well, I don't think it's messy per se, I mean it's alphabetical, but perhaps it would be clearer to group them into negative forces, neutral, and positive.
it appears that a "former programmer admin" is an illegal user type. But your sub will give it a strong trust_level.
This is an interesting worry. On the one hand, I've got a variety of ways to solve it, from doing another if-else to see if there's a violation of the 'former' || ('admin' || 'trainee') rule (icky), or I could make 'former' be worth a greater negative value (hackish), or do a forward lookahead in the regex I suppose (not bad). But on the other hand, these values come from UserType objects whose values are constrained by a database table, so to construct an invalid usertype would require admin privileges on the DB. And at that point the system is totally compromised anyway.
Thanks again for the feedback!
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Assigning Opsets by User Type
by Abigail-II (Bishop) on Nov 20, 2002 at 18:06 UTC |