Re: select * and bind_cols considered harmful

Sorry, but I'm flabbergasted that anyone would ever use "select *" in a real program! That is the bug waiting to happen, not bind_cols.

I think typing out the list of lexical variables is worth the extra speed. There is some data on the speed difference in Tim Bunce's talk.

Of course, if speed makes no difference in your application then use whatever you like.

Comment on Re: select * and bind_cols considered harmful Select or Download Code

Replies are listed 'Best First'.
Re: Re: select * and bind_cols considered harmful by blssu (Pilgrim) on Nov 22, 2002 at 18:56 UTC
I'd categorize them as different kinds of bugs. The `select *` with `fetchrow_hashref` can lead to performance problems, but the `bind_cols` can completely break things. During code reviews I tell people to select explicit columns and use `fetchrow_hashref`. I know people are sometimes going to break standards and ignore my advice. There are three options I know of: (1) give them standards that will probably keep working even if not perfectly followed, (2) audit all code for compliance, (3) fire people who write bad code. Option (1) is my pragmatic choice. What's yours?	[reply] [d/l] [select]
Re: Re: Re: select * and bind_cols considered harmful by perrin (Chancellor) on Nov 22, 2002 at 19:18 UTC
Easy, it's nothing personal. Select * with fetchrow_hashref will break in confusing ways if a column name is changed, but will survive columns being added. Of course performance will get progressively worse as columns get added even if they aren't being used. Regardless, select * is obviously a bad practice and fetchrow_hashref is just a band-aid that hides some of the badness. The DBAs at most jobs I've had would have hung me from the rafters if I used select * in production code.	[reply]