Re: Context of "if" statements?

You're not skipping the lines, that's why. You always assign and print regardless. What about this:

while (<INFILE>)
{
     next if /^#/;

     my ($infile, $dir, $type) = split;
     print "$infile $dir $type\n";
}
[download]

A few refinements can be made if you don't care about what you're printing:

while (<INFILE>)
{
     next if /^#/;

     my @split = (split)[0..2];
     print "@split\n";
}
[download]

Use next to idiomatically skip to the next valid line.

You are probably getting warnings too. You've used $infile and $inifile where I think you mean only one of the two.

Comment on Re: Context of "if" statements? Select or Download Code

Replies are listed 'Best First'.
Re: Re: Context of "if" statements? by ibanix (Hermit) on Nov 24, 2002 at 03:29 UTC
You are correct, `$infile` is a typo. Is still do not understand why `(my $server, my $dir, my $type) = split if !/^#/` [download] does not work (that is, it splits every line), and `print if !/^#/` [download] does work (it only prints lines not starting with #). What's the difference? <-> In general, we find that those who disparage a given operating system, language, or philosophy have never had to use it in practice. <->	[reply] [d/l] [select]
Re^3: Context of "if" statements? by tadman (Prior) on Nov 24, 2002 at 04:25 UTC
Having my in the same context as a trailing `if` is usually bad form. As far as I can tell, the variables are declared regardless of the outcome of the `if` and are scoped to the block. In plain english, this means that the split is not occuring, but the variables are there, and you are still printing because there is no conditional on the print. That's why I suggested using a next call to skip to the next line. If it is a comment, there's no point in calling either split or print, is there? Update: For additional clarity, here's an example of what's happening: `while (<INFILE>) { my ($infile, $dir, $type); if (!/^#/) { ($infile, $dir, $type) = split; } print "$infile $dir $type\n"; }` [download]	[reply] [d/l] [select]