in reply to Compressed content module

Looks fine. There are a few stylistic, efficiency, and configurability things though. I'd inline the test of Accept-Encoding myself. (Update)It would probably be better to use read with something like a 4k chunk at a time instead of linewise (Update: when passing compressed content), especially considering it's a binary file and $/ may not even occur in the file for some platforms (think \r\n). Finally, I'd consider letting the user somehow define the extension(s), or perhaps MIME-types to support decompression for.

UPDATE: As for SSI you might mention that the user could instead construct a skeleton document with the existing SSI and then include a body handled by this module as an SSI.

--
I'm not belgian but I play one on TV.

Replies are listed 'Best First'.
Re: Re: Compressed content module
by simon.proctor (Vicar) on Dec 01, 2002 at 23:01 UTC
    Thanks for the feedback, I'll be updating the code and update the root node. One question though. You mentioned letting the user define the extensions however it does this straight out of the box: 
    <FilesMatch "\.chtml$">
  SetHandler perl-script
  PerlHandler Apache::Precompress
</FilesMatch>

    [download]
    Is this something along the lines of what you meant (I kinda like the chtml extension :) )? If not could you give me an example?

    Thanks once again, SP
[reply]
[d/l]
      Doh! I forgot about File and friends. That is one way for the user to do so, and a good one too. I'd actually slightly mangled the module logic in my head there (the test for gz suffix). I'd recommend giving an example of that in the documentation (BTW MS uses CHTML for compiled HTML, there's also cHTML - compact HTML). Also, you might want to remove the test for gz extension and look for magic a la file(1). It's more UN*Xy, even if it is more expensive.

      --
      I'm not belgian but I play one on TV.

[reply]

        GZip magic is easy - The first two bytes are "\x1f\x8b". You can also check for compress which I recall is "\x1f\x9b" though you may want to check.

        __SIG__
use B;
printf "You are here %08x\n", unpack "L!", unpack "P4", pack
  "L!", B::svref_2object(sub{})->OUTSIDE;

        [download]
[reply]
[d/l]

In Section Cool Uses for Perl